Update browser-ui-test version and improve rustdoc-gui tests readability #91834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
the
T-rustdoc
camelid
added
the
S-waiting-on-review
|
@rustbot assign @notriddle |
|
I guess rustbot is away. :) |
|
No, there's just a bug (?) with GitHub where notriddle can't be assigned to PRs. I don't understand it 🤷 |
|
O.o |
|
r? @jsha |
|
@bors r+ rollup
…On Sat, Dec 18, 2021, 11:43 Rust highfive robot ***@***.***> wrote:
Assigned #91834 <#91834> to @jsha
<https://github.com/jsha>.
—
Reply to this email directly, view it on GitHub
<#91834 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABVYLNLLNSCQMHTKY3QVD3URTP47ANCNFSM5J4PLKGA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
|
📌 Commit 6325086 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 19, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91834 (Update browser-ui-test version and improve rustdoc-gui tests readability) - rust-lang#91894 (Remove `in_band_lifetimes` from `rustc_incremental`) - rust-lang#91932 (Add user seed to `-Z randomize-layout`) - rust-lang#91956 (fix(rustc_lint): better detect when parens are necessary) - rust-lang#92020 (Remove P: Unpin bound on impl Stream for Pin) - rust-lang#92063 (docs: fix typo) - rust-lang#92082 (rustdoc: Write doc-comments directly instead of using FromIterator) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
0.5.1, we can use trailing commas. I also used the opportunity to clean up the existing tests.r? @notriddle