Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user seed to -Z randomize-layout #91932

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Conversation

Kixiron
Copy link
Member

@Kixiron Kixiron commented Dec 14, 2021

Allows users of -Z randomize-layout to provide -Z layout-seed=<seed> in order to further randomizing type layout randomization. Extension of compiler-team/#457, allows users to change struct layouts without changing code and hoping that item path hashes change, aiding in detecting layout errors

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 14, 2021
@rust-highfive
Copy link
Collaborator

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2021
@nagisa
Copy link
Member

nagisa commented Dec 14, 2021

What is the underlying motivation for wanting to specify a seed to randomize-layout? Can you spell that out in the PR description?

@Kixiron
Copy link
Member Author

Kixiron commented Dec 14, 2021

Edited

@camelid camelid added the A-layout Area: Memory layout of types label Dec 15, 2021
@nagisa
Copy link
Member

nagisa commented Dec 18, 2021

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Dec 18, 2021

📌 Commit 2af02ab has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2021
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#91834 (Update browser-ui-test version and improve rustdoc-gui tests readability)
 - rust-lang#91894 (Remove `in_band_lifetimes` from `rustc_incremental`)
 - rust-lang#91932 (Add user seed to `-Z randomize-layout`)
 - rust-lang#91956 (fix(rustc_lint): better detect when parens are necessary)
 - rust-lang#92020 (Remove P: Unpin bound on impl Stream for Pin)
 - rust-lang#92063 (docs: fix typo)
 - rust-lang#92082 (rustdoc: Write doc-comments directly instead of using FromIterator)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6b62bf3 into rust-lang:master Dec 19, 2021
@rustbot rustbot added this to the 1.59.0 milestone Dec 19, 2021
@workingjubilee workingjubilee added the -Zrandomize-layout Unstable option: Randomize the layout of types. label Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Zrandomize-layout Unstable option: Randomize the layout of types. A-layout Area: Memory layout of types S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants