-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Provider api to core::any #91970
Conversation
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #93548) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking a while for getting to this.
While some of the comments I'm confident in, others I'm not tied to at all. As always, feel free to push back on anything you feel differently about.
@scottmcm thanks for the review, they were very useful comments. I think I have addressed the comments, please take another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clippy gives two suggestions, I added them as a review. 🙂
Signed-off-by: Nick Cameron <[email protected]>
… is not required Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Signed-off-by: Nick Cameron <[email protected]>
Comments addressed |
Thanks for the updates! Things look good to me. @bors r+ (And sorry for taking a while to rereview after the changes.) |
📌 Commit 6629010 has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (e9aff9c): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
This is an implementation of RFC 3192
(which is yet to be merged, thus why this is a draft PR). It adds an API for type-driven requests and provision of data from trait objects. A primary use case is for theError
trait, though that is not implemented in this PR. The only major difference to the RFC is that the functionality is added to theany
module, rather than being in a siblingprovide_any
module (as discussed in the RFC thread).Still todo: improve documentation on items, including adding examples.cc @yaahc