Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Provider api to core::any #91970
Add the Provider api to core::any #91970
Changes from all commits
bb5db85
57d027d
17730e6
e82368d
2e0ca25
843f90c
6629010
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm puzzled by the need for
MaybeSizedType
/MaybeSizedValue
here.Why can't
Ref
take something optionally-sized all the time?Maybe an update to the doc comment could help? The comment referencing
T
, which doesn't actually exist as a type parameter for it, makes it hard for me to follow. I think it's a tag for reference-to-I::Reified
, if I'm reading the rest of the module correctly?And every use of
Ref
(other that trait impls) seems to betags::Ref<tags::MaybeSizedValue<T>>
. I can't see any place that would wanttags::Ref<tags::Value<T>>
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try and add some docs to clarify. Essentially, it is not the
I
which is sized/unsized, but the type whichI
represents (I::Reified
)