Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 16 pull requests #92784

Closed
wants to merge 34 commits into from

Commits on Dec 8, 2021

  1. std::path::absolute

    ChrisDenton committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    0660732 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Configuration menu
    Copy the full SHA
    60ec6a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Configuration menu
    Copy the full SHA
    7fd6ddf View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2022

  1. Display "private fields" instead of "fields omitted"

    Also:
    
      * Always use `/* */` block comments
      * Use the same message everywhere, rather than sometimes prefixing
        with "some"
    
    When I first read rustdoc docs, I was confused why the fields were being
    omitted. It was only later that I realized it was because they were
    private. It's also always bothered me that rustdoc sometimes uses `//`
    and sometimes uses `/*` comments for these messages, so this change
    makes them all use `/*`.
    
    Technically, I think fields can be omitted if they are public but
    `doc(hidden)` too, but `doc(hidden)` is analogous to privacy. It's
    really just used to emulate "doc privacy" when -- because of technical
    limitations -- an item has to be public. So I think it's fine to include
    this under the category of "private fields".
    camelid committed Jan 9, 2022
    Configuration menu
    Copy the full SHA
    2b70a3d View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Configuration menu
    Copy the full SHA
    8fd8db5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    680ebea View commit details
    Browse the repository at this point in the history
  3. Fix doc formatting for time.rs

    The doc states that instants are not steady, but the word "not" wasn't highlighted in bold.
    rosik authored Jan 10, 2022
    Configuration menu
    Copy the full SHA
    2ae616a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    55abf38 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    881b427 View commit details
    Browse the repository at this point in the history
  6. Eliminate "boxed" wording in std::error::Error documentation

    In commit 29403ee, documentation for the methods on `std::any::Any` was
    modified so that they referred to the concrete value behind the trait
    object as the "inner" value. This is a more accurate wording than
    "boxed": while putting trait objects inside boxes is arguably the most
    common use, they can also be placed behind other pointer types like
    `&mut` or `std::sync::Arc`.
    
    This commit does the same documentation changes for `std::error::Error`.
    david-perez committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    5786bbd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    fc8af98 View commit details
    Browse the repository at this point in the history
  8. Improve documentation for File::options to give a more likely example

    `File::options().read(true).open(...)` is equivalent to just
    `File::open`. Change the example to set the `append` flag instead, and
    then change the filename to something more likely to be written in
    append mode.
    joshtriplett authored and Mark-Simulacrum committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    c91ad5d View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Update AsmArgs field visibility for rustfmt

    To more easily allow rustfmt to format the asm! macro as specified in
    rust-lang/style-team#152 certain fields are made public.
    ytmimi committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    11bea26 View commit details
    Browse the repository at this point in the history
  2. ⬆️ rust-analyzer

    lnicola committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    22d4e97 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9234c0f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24c6e96 View commit details
    Browse the repository at this point in the history
  5. Add test

    fee1-dead committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    bf5130b View commit details
    Browse the repository at this point in the history
  6. fs: Use readdir() instead of readdir_r() on Linux

    readdir() is preferred over readdir_r() on Linux and many other
    platforms because it more gracefully supports long file names.  Both
    glibc and musl (and presumably all other Linux libc implementations)
    guarantee that readdir() is thread-safe as long as a single DIR* is not
    accessed concurrently, which is enough to make a readdir()-based
    implementation of ReadDir safe.  This implementation is already used for
    some other OSes including Fuchsia, Redox, and Solaris.
    
    See rust-lang#40021 for more details.  Fixes rust-lang#86649.
    tavianator committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ea9181b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#91673 - ChrisDenton:path-absolute, r=Mark-S…

    …imulacrum
    
    `std::path::absolute`
    
    Implements rust-lang#59117 by adding a `std::path::absolute` function that creates an absolute path without reading the filesystem. This is intended to be a drop-in replacement for [`std::fs::canonicalize`](https://doc.rust-lang.org/std/fs/fn.canonicalize.html) in cases where it isn't necessary to resolve symlinks. It can be used on paths that don't exist or where resolving symlinks is unwanted. It can also be used to avoid circumstances where `canonicalize` might otherwise fail.
    
    On Windows this is a wrapper around [`GetFullPathNameW`](https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-getfullpathnamew). On Unix it partially implements the POSIX [pathname resolution](https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_13) specification, stopping just short of actually resolving symlinks.
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    24b4c3f View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#92328 - camelid:sentence, r=scottmcm

    Tweak sentence in `transmute` docs
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    b1f52e5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#92432 - fee1-dead:constck-impl-constness, r…

    …=oli-obk
    
    Error when selected impl is not const in constck
    
    Catches bad things when checking a `default_method_body_is_const` body, such as:
    
    ```rust
    self.map(/* .. */).is_sorted();
    ```
    
    When `Map` does not yet have a `const` `impl` for `Iterator`.
    
    r? `@oli-obk`
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    c92b910 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#92506 - nico-abram:uwu, r=Mark-Simulacrum

    Document Box<T> FFI guarantee in 1.41.0 release notes
    
    Fixes rust-lang#68676
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    1d97d61 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#92699 - camelid:private-fields, r=jsha

    rustdoc: Display "private fields" instead of "fields omitted"
    
    Also:
    
      * Always use `/* */` block comments
      * Use the same message everywhere, rather than sometimes prefixing
        with "some"
    
    When I first read rustdoc docs, I was confused why the fields were being
    omitted. It was only later that I realized it was because they were
    private. It's also always bothered me that rustdoc sometimes uses `//`
    and sometimes uses `/*` comments for these messages, so this change
    makes them all use `/*`.
    
    Technically, I think fields can be omitted if they are public but
    `doc(hidden)` too, but `doc(hidden)` is analogous to privacy. It's
    really just used to emulate "doc privacy" when -- because of technical
    limitations -- an item has to be public. So I think it's fine to include
    this under the category of "private fields".
    
    r? `@jsha`
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    f05cb54 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#92703 - joshtriplett:relnotes-file-options,…

    … r=pietroalbini
    
    RELEASES.md: Add 1.58 release note for `File::options` stabilization
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    e0d69b6 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#92707 - JohnScience:patch-1, r=GuillaumeGomez

    Extended the note on the use of `no_run` attribute
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    9e0243c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#92709 - joshtriplett:file-options-docs, r=M…

    …ark-Simulacrum
    
    Improve documentation for File::options to give a more likely example
    
    `File::options().read(true).open(...)` is equivalent to just
    `File::open`. Change the example to set the `append` flag instead, and
    then change the filename to something more likely to be written in
    append mode.
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    12f4d1e View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#92720 - rosik:patch-1, r=m-ou-se

    Fix doc formatting for time.rs
    
    The doc states that instants are not steady, but the word "not" wasn't highlighted in bold.
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    a5b7409 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#92732 - wesleywiser:note_musl_patch_info, r…

    …=Mark-Simulacrum
    
    Add note about upstream commit musl-patch-configure.diff is derived from
    
    The patch landed in upstream over the weekend so I'm adding a note so we can more easily track when our patch file can be removed.
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    717bde7 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#92742 - GuillaumeGomez:missing-suffix-sideb…

    …ar-items, r=notriddle
    
    Add missing suffix for sidebar-items script path
    
    Fixes rust-lang/docs.rs#1590.
    
    r? `@syphar`
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    f4f5755 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#92748 - david-perez:eliminate-boxed-wording…

    …-std-error, r=Mark-Simulacrum
    
    Eliminate "boxed" wording in `std::error::Error` documentation
    
    In commit 29403ee, documentation for the methods on `std::any::Any` was
    modified so that they referred to the concrete value behind the trait
    object as the "inner" value. This is a more accurate wording than
    "boxed": while putting trait objects inside boxes is arguably the most
    common use, they can also be placed behind other pointer types like
    `&mut` or `std::sync::Arc`.
    
    This commit does the same documentation changes for `std::error::Error`.
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    0746587 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#92754 - ytmimi:AsmArgs-field-visibility, r=…

    …calebcartwright
    
    Update AsmArgs field visibility for rustfmt
    
    To more easily allow rustfmt to format the ``asm!`` macro as specified in
    rust-lang/style-team#152 certain fields are made public.
    
    r? `@calebcartwright`
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    a22e77f View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#92756 - lnicola:rust-analyzer-2022-01-11, r…

    …=lnicola
    
    ⬆️ rust-analyzer
    
    r? `@ghost`
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    d0440de View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#92764 - GuillaumeGomez:fix-rust-logo-style,…

    … r=jsha
    
    Fix rust logo style
    
    The style on the rust logo is currently broken:
    
    ![Screenshot from 2022-01-11 13-36-30](https://user-images.githubusercontent.com/3050060/148946754-a1a57253-bed0-44cf-a41c-83e0eecbd6b5.png)
    
    With this fix, we're back to normal:
    
    ![Screenshot from 2022-01-11 13-42-07](https://user-images.githubusercontent.com/3050060/148946778-99f44678-aac1-419f-bb8c-ffa837e0c1ee.png)
    
    I also used a GUI test to prevent future silent regressions.
    
    r? `@jsha`
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    18fa47c View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#92778 - tavianator:linux-readdir-no-r, r=jo…

    …shtriplett
    
    fs: Use readdir() instead of readdir_r() on Linux
    
    readdir() is preferred over readdir_r() on Linux and many other
    platforms because it more gracefully supports long file names.  Both
    glibc and musl (and presumably all other Linux libc implementations)
    guarantee that readdir() is thread-safe as long as a single DIR* is not
    accessed concurrently, which is enough to make a readdir()-based
    implementation of ReadDir safe.  This implementation is already used for
    some other OSes including Fuchsia, Redox, and Solaris.
    
    See rust-lang#40021 for more details.  Fixes rust-lang#86649.
    matthiaskrgr authored Jan 11, 2022
    Configuration menu
    Copy the full SHA
    efcc300 View commit details
    Browse the repository at this point in the history