Rollup of 14 pull requests #92811
Merged
Rollup of 14 pull requests #92811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also:
* Always use `/* */` block comments
* Use the same message everywhere, rather than sometimes prefixing
with "some"
When I first read rustdoc docs, I was confused why the fields were being
omitted. It was only later that I realized it was because they were
private. It's also always bothered me that rustdoc sometimes uses `//`
and sometimes uses `/*` comments for these messages, so this change
makes them all use `/*`.
Technically, I think fields can be omitted if they are public but
`doc(hidden)` too, but `doc(hidden)` is analogous to privacy. It's
really just used to emulate "doc privacy" when -- because of technical
limitations -- an item has to be public. So I think it's fine to include
this under the category of "private fields".
The doc states that instants are not steady, but the word "not" wasn't highlighted in bold.
In commit 29403ee, documentation for the methods on `std::any::Any` was modified so that they referred to the concrete value behind the trait object as the "inner" value. This is a more accurate wording than "boxed": while putting trait objects inside boxes is arguably the most common use, they can also be placed behind other pointer types like `&mut` or `std::sync::Arc`. This commit does the same documentation changes for `std::error::Error`.
`File::options().read(true).open(...)` is equivalent to just `File::open`. Change the example to set the `append` flag instead, and then change the filename to something more likely to be written in append mode.
To more easily allow rustfmt to format the asm! macro as specified in rust-lang/style-team#152 certain fields are made public.
Tweak sentence in `transmute` docs
…=oli-obk Error when selected impl is not const in constck Catches bad things when checking a `default_method_body_is_const` body, such as: ```rust self.map(/* .. */).is_sorted(); ``` When `Map` does not yet have a `const` `impl` for `Iterator`. r? ```@oli-obk```
Document Box<T> FFI guarantee in 1.41.0 release notes Fixes rust-lang#68676
rustdoc: Display "private fields" instead of "fields omitted"
Also:
* Always use `/* */` block comments
* Use the same message everywhere, rather than sometimes prefixing
with "some"
When I first read rustdoc docs, I was confused why the fields were being
omitted. It was only later that I realized it was because they were
private. It's also always bothered me that rustdoc sometimes uses `//`
and sometimes uses `/*` comments for these messages, so this change
makes them all use `/*`.
Technically, I think fields can be omitted if they are public but
`doc(hidden)` too, but `doc(hidden)` is analogous to privacy. It's
really just used to emulate "doc privacy" when -- because of technical
limitations -- an item has to be public. So I think it's fine to include
this under the category of "private fields".
r? ```@jsha```
… r=pietroalbini RELEASES.md: Add 1.58 release note for `File::options` stabilization
Extended the note on the use of `no_run` attribute
…ark-Simulacrum Improve documentation for File::options to give a more likely example `File::options().read(true).open(...)` is equivalent to just `File::open`. Change the example to set the `append` flag instead, and then change the filename to something more likely to be written in append mode.
Fix doc formatting for time.rs The doc states that instants are not steady, but the word "not" wasn't highlighted in bold.
…=Mark-Simulacrum Add note about upstream commit musl-patch-configure.diff is derived from The patch landed in upstream over the weekend so I'm adding a note so we can more easily track when our patch file can be removed.
…ar-items, r=notriddle Add missing suffix for sidebar-items script path Fixes rust-lang/docs.rs#1590. r? ```@syphar```
…-std-error, r=Mark-Simulacrum Eliminate "boxed" wording in `std::error::Error` documentation In commit 29403ee, documentation for the methods on `std::any::Any` was modified so that they referred to the concrete value behind the trait object as the "inner" value. This is a more accurate wording than "boxed": while putting trait objects inside boxes is arguably the most common use, they can also be placed behind other pointer types like `&mut` or `std::sync::Arc`. This commit does the same documentation changes for `std::error::Error`.
…calebcartwright Update AsmArgs field visibility for rustfmt To more easily allow rustfmt to format the ``asm!`` macro as specified in rust-lang/style-team#152 certain fields are made public. r? ```@calebcartwright```
…=lnicola ⬆️ rust-analyzer r? ```@ghost```
… r=jsha Fix rust logo style The style on the rust logo is currently broken:  With this fix, we're back to normal:  I also used a GUI test to prevent future silent regressions. r? ```@jsha```
rustbot
added
T-compiler
|
@bors r+ rollup=never p=14 |
|
📌 Commit 05dd1e4 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 05dd1e4 with merge 19e9e08c7854deac0f535918255a11702cb5a887... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry i686-msvc-1 and x86_64_msvc-1 timout, everything else was green |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (1bd4fdc): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
transmutedocs #92328 (Tweak sentence intransmutedocs)File::optionsstabilization #92703 (RELEASES.md: Add 1.58 release note forFile::optionsstabilization)no_runattribute #92707 (Extended the note on the use ofno_runattribute)std::error::Errordocumentation #92748 (Eliminate "boxed" wording instd::error::Errordocumentation)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup