-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"name resolution" #16
Comments
Hello. Could I have a try with this one? Few notes:
|
@vorner sounds good to me! One of the things I've been wrestling with, as an aside, is just how much detail this guide should go into. I don't think it should replace "in-code" comments -- that is, we don't want the material to become outdated very regularly. We'll have to feel our way. To that end, I was thinking that perhaps a good place to start would be to dive into the code and try to add comments explaining how it works. This will of course be kind of "bottom up" -- at some point then we should be able to decide what of that material should go into guide, which should go into the code itself. Anyway, let me know how things are going. I'll try to check in from time to time. |
My idea was to do the comments in code (if I find places where the code isn't self-documenting and find them missing) and then try to write a high level picture with very little details. I guess it'll need some more iteration later on, and details can always be added. |
@vorner sounds perfect |
Ping @vorner ? Did you wish to continue iterating on this chapter? |
Ping @vorner ? |
Sorry, I was busy and missed the previous ping :-|. Yes, I still want to have a second go through the code, put comments on there and polish the text in the chapter and possibly add some more details. But if I'm taking too long, I'd definitely understand if someone else wants to take it over (though it seems there's plenty of other work available). |
No worries! I just was making sure you were still interested :) |
…chenkov Some comments and documentation for name resolution crate Hello I'm trying to get a grasp of how the name resolution crate works, as part of helping with rust-lang/rustc-dev-guide#16. Not that I'd be succeeding much, but as I was reading the code, I started to put some notes into it, to help me understand. I guess I didn't get very far yet, but I'd like to share what I have, in case it might be useful for someone else. I hope these are correct (even if incomplete), but I'll be glad for a fast check in case I put something misleading there.
…chenkov Some comments and documentation for name resolution crate Hello I'm trying to get a grasp of how the name resolution crate works, as part of helping with rust-lang/rustc-dev-guide#16. Not that I'd be succeeding much, but as I was reading the code, I started to put some notes into it, to help me understand. I guess I didn't get very far yet, but I'd like to share what I have, in case it might be useful for someone else. I hope these are correct (even if incomplete), but I'll be glad for a fast check in case I put something misleading there.
Thank you for your work on this guide, it's really helpful.
|
Did you ever find out anything about this? |
If it is question aimed at me, then no. Whatever I discovered through the code has been put into the text. |
It says ribs were explained as part of #21, but that doesn't seem to be the case. I can't see them mentioned anywhere, including the glossary. |
We should be talking about the
librustc_resolve
crate works here. Some topics of interest:pub use
and stuff like that workThe text was updated successfully, but these errors were encountered: