Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second pass of name resolution #73

Merged
merged 1 commit into from
Mar 4, 2018
Merged

Second pass of name resolution #73

merged 1 commit into from
Mar 4, 2018

Conversation

vorner
Copy link
Contributor

@vorner vorner commented Mar 3, 2018

Hello

I found a bit of more time for the name resolution (#16) and put some more stuff there.

However, I'm afraid the whole chapter is above my abilities (or time, at least) to document reasonably ‒ I'm reading through the code and still don't understand most of it and have no idea about which part of code relates to the other bullet points in the issue description. Therefore, if there's someone else who might want to have a look at it, I'd like to release the lock on the task and I'll find some other way to contribute to rust (pull requests to random crates I use seem to have better cost-effect ratio for me).

Just small little tweaks
@vorner vorner changed the title WIP: Second pass of name resolution Second pass of name resolution Mar 3, 2018
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vorner!

@mark-i-m
Copy link
Member

mark-i-m commented Mar 4, 2018

If you want, there are a bunch of other issues on this repo that may have lower time commitments: https://github.com/rust-lang-nursery/rustc-guide/labels/help%20wanted

(Of course, please don't feel obligated in any way!)

If it helps:

  • There's also usually a "Help wanted" section in https://this-week-in-rust.org

  • And there are also sometimes mentored issues in the rust repo itself.

@mark-i-m mark-i-m merged commit 23b3e84 into rust-lang:master Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants