Spelling #5753

jsoref · 2023-04-14T13:24:00Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/rustfmt/actions/runs/4700253156#summary-12752086000

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/rustfmt/actions/runs/4700253432#summary-12752087472

jsoref

Most spelling corrections automatically suggested by Google Sheets (when being run on the rust repository). I've manually transplanted these commits into this repository.

All fault mine.

jsoref · 2023-04-14T13:24:22Z

CHANGELOG.md

- Do not remove path disambiugator inside macro #3142
+- Do not remove path disambiguator inside macro #3142


Some projects don't like changing change logs. Happy to drop.

jsoref · 2023-04-14T13:24:35Z

CHANGELOG.md

- Replace '--conifig-help' with '--config=help' cb10e06
+- Replace '--config-help' with '--config=help' cb10e06


It's possible this means what it said, but I'm guessing it didn't.

jsoref · 2023-04-14T13:24:55Z

CHANGELOG.md

- Implement stable ordering for impl items with the the following item priority: type, const, macro, then method fa80ddf
+- Implement stable ordering for impl items with the following item priority: type, const, macro, then method fa80ddf


Doubled words aren't technically misspellings, but spell checkers have traditionally flagged them as well

jsoref · 2023-04-14T13:25:07Z

intellij.md

- IntellJ uses autosave, so now your files will always be formatted according to rustfmt. Alternatively you can use Ctrl+S to reformat file manually
+- IntelliJ uses autosave, so now your files will always be formatted according to rustfmt. Alternatively you can use Ctrl+S to reformat file manually


jsoref · 2023-04-14T13:26:32Z

src/config/config_type.rs

-    // Options passed in to the macro.
+    // Options passed into the macro.


in to/into has been quite controversial. It's possible that the phrase pass-in is being treated as a thing in which case I could understand someone objecting, but, I parse this as pass options into container, and thus into is my preference.

tests/target/configs/indent_style/block_tab_spaces_call.rs

tests/target/issue-5125/attributes_in_formal_function_parameter.rs

tests/target/no_arg_with_comment.rs

tests/target/no_arg_with_commnet.rs

tests/target/multi-file.rs

tests/source/expr.rs

calebcartwright · 2023-06-19T15:21:02Z

Thank you for this. I think there's some objective fixes here that we want to include, but I have some reservations about there being changes proposed under the tests directory. Often times these files consist of content that was copy/pasted from a user report/minimal repro so the spelling issues aren't particularly relevant.

However, within those tests there are other cases of intentional grammar issues to do things like hitting a certain column width, and while the tests will still pass if those are changed, the the grammar fix would (silently) break the semantics of the test. It's a really, really subtle (and mildly annoying) thing, but it's because of that factor that I feel like we'd need to do a really deep dive review of the proposed tests changes to ensure that fringe case wouldn't happen here, and we're not going to have the capacity to do that any time soon.

If you'd be up for splitting out the non-tests changes into a separate PR (or dropping the tests changes from this one) then we could go ahead and move forward with that. Otherwise this will probably be parked for the foreseeable future

jsoref · 2023-06-19T15:55:38Z

Splitting out tests isn't a problem. Maybe tomorrow...

ytmimi · 2024-01-25T03:47:57Z

@jsoref any chance you're still interested in working on this one? If not I think we should close the PR

jsoref · 2024-01-25T03:48:46Z

Sorry. Lemme look now.

ytmimi · 2024-01-25T04:08:46Z

src/syntax.rs

@jsoref can you revert this rename. I think it's likely that the syntux.rs file is no longer used and needs to be deleted (probably best to delete it in a different PR). The syntux mod was renamed to parse back in #5143

Done. And yes, if you're up for creating a PR for the cleanup, that'd be wonderful. I have limited spurts of energy and one good thing about my PRs is they tend to identify other cleanup that projects can do.

(I can try to do it, but I'm likely to get distracted...)

Yeah, no worries. I'll handle the deletion. I appreciate the work you've already done 🙏🏼

jsoref · 2024-01-25T04:49:06Z

Fwiw, these additional corrections probably postdate the version of rustfmt that was originally checked for this PR: https://github.com/jsoref/rustfmt/compare/5313c939ecb58788824a93e3629c9b00de25a9f3..d955b537

If you like, I can add them in, if you'd rather they wait, that's also ok.

ytmimi · 2024-01-25T16:17:26Z

Fwiw, these additional corrections probably postdate the version of rustfmt that was originally checked for this PR: https://github.com/jsoref/rustfmt/compare/5313c939ecb58788824a93e3629c9b00de25a9f3..d955b537

If you like, I can add them in, if you'd rather they wait, that's also ok.

Yes, please add these additional changes if you can!

ci/check_diff.sh

src/config/mod.rs

Signed-off-by: Josh Soref <[email protected]>

ytmimi

Thanks again for helping to make these changes!

jsoref commented Apr 14, 2023

View reviewed changes

ytmimi added the pr-not-reviewed label Apr 14, 2023

jsoref mentioned this pull request Apr 16, 2023

Spelling rust-lang/rust#110392

Closed

kadiwa4 reviewed Apr 17, 2023

View reviewed changes

tests/source/expr.rs Outdated Show resolved Hide resolved

iamwacko mentioned this pull request Jun 4, 2023

Remove repeated definite articles #5759

Closed

jsoref force-pushed the spelling branch from 37cb8d0 to 9dba7c7 Compare January 25, 2024 03:52

ytmimi reviewed Jan 25, 2024

View reviewed changes

jsoref force-pushed the spelling branch from 9dba7c7 to 2ed0604 Compare January 25, 2024 04:11

ytmimi added pr-waiting-on-author and removed pr-not-reviewed labels Jan 25, 2024

jsoref force-pushed the spelling branch from 2ed0604 to af12eb5 Compare January 25, 2024 16:26

jsoref commented Jan 25, 2024

View reviewed changes

ci/check_diff.sh Show resolved Hide resolved

src/config/mod.rs Show resolved Hide resolved

jsoref added 12 commits January 25, 2024 16:38

spelling: config

7b3ab3d

Signed-off-by: Josh Soref <[email protected]>

spelling: definition

1ffd8fc

Signed-off-by: Josh Soref <[email protected]>

spelling: disambiguator

b5e2bd4

Signed-off-by: Josh Soref <[email protected]>

spelling: existential

8d06ab4

Signed-off-by: Josh Soref <[email protected]>

spelling: explicitly

a4f9edb

Signed-off-by: Josh Soref <[email protected]>

spelling: flattened

4c98226

Signed-off-by: Josh Soref <[email protected]>

spelling: globals

6106ba9

Signed-off-by: Josh Soref <[email protected]>

spelling: identified

64d2790

Signed-off-by: Josh Soref <[email protected]>

spelling: ignorable

d117add

Signed-off-by: Josh Soref <[email protected]>

spelling: inclusive

1746baa

Signed-off-by: Josh Soref <[email protected]>

spelling: initialized

561495e

Signed-off-by: Josh Soref <[email protected]>

spelling: intellij

5a2a281

Signed-off-by: Josh Soref <[email protected]>

jsoref added 14 commits January 25, 2024 16:38

spelling: into

4a45e93

Signed-off-by: Josh Soref <[email protected]>

spelling: multi

a839a59

Signed-off-by: Josh Soref <[email protected]>

spelling: multiline

9702b45

Signed-off-by: Josh Soref <[email protected]>

spelling: neither/nor

16193c5

Signed-off-by: Josh Soref <[email protected]>

spelling: nonexistent

b59d77f

Signed-off-by: Josh Soref <[email protected]>

spelling: resolving

caf9aab

Signed-off-by: Josh Soref <[email protected]>

spelling: rustc

62dd5f2

Signed-off-by: Josh Soref <[email protected]>

spelling: semantics

ce555ad

Signed-off-by: Josh Soref <[email protected]>

spelling: several

11c902b

Signed-off-by: Josh Soref <[email protected]>

spelling: submodule

a69d07c

Signed-off-by: Josh Soref <[email protected]>

spelling: submodules

2781afc

Signed-off-by: Josh Soref <[email protected]>

spelling: the

ef9e1c6

Signed-off-by: Josh Soref <[email protected]>

spelling: there

8a26a30

Signed-off-by: Josh Soref <[email protected]>

spelling: version

9e6444f

Signed-off-by: Josh Soref <[email protected]>

ytmimi force-pushed the spelling branch from af12eb5 to 9e6444f Compare January 25, 2024 23:38

ytmimi approved these changes Jan 25, 2024

View reviewed changes

ytmimi merged commit cedb7b5 into rust-lang:master Jan 25, 2024
27 checks passed

ytmimi removed the pr-waiting-on-author label Jan 25, 2024

jsoref deleted the spelling branch January 26, 2024 00:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #5753

Spelling #5753

jsoref commented Apr 14, 2023

jsoref left a comment

jsoref Apr 14, 2023

jsoref Apr 14, 2023

jsoref Apr 14, 2023

jsoref Apr 14, 2023

jsoref Apr 14, 2023

calebcartwright commented Jun 19, 2023 •

edited

Loading

jsoref commented Jun 19, 2023

ytmimi commented Jan 25, 2024

jsoref commented Jan 25, 2024

ytmimi Jan 25, 2024

jsoref Jan 25, 2024

ytmimi Jan 25, 2024

jsoref commented Jan 25, 2024

ytmimi commented Jan 25, 2024

ytmimi left a comment

		- Do not remove path disambiugator inside macro #3142
		- Do not remove path disambiguator inside macro #3142

		- Replace '--conifig-help' with '--config=help' cb10e06
		- Replace '--config-help' with '--config=help' cb10e06

		- Implement stable ordering for impl items with the the following item priority: type, const, macro, then method fa80ddf
		- Implement stable ordering for impl items with the following item priority: type, const, macro, then method fa80ddf

		- IntellJ uses autosave, so now your files will always be formatted according to rustfmt. Alternatively you can use Ctrl+S to reformat file manually
		- IntelliJ uses autosave, so now your files will always be formatted according to rustfmt. Alternatively you can use Ctrl+S to reformat file manually

		// Options passed in to the macro.
		// Options passed into the macro.

Spelling #5753

Spelling #5753

Conversation

jsoref commented Apr 14, 2023

jsoref left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

calebcartwright commented Jun 19, 2023 • edited Loading

jsoref commented Jun 19, 2023

ytmimi commented Jan 25, 2024

jsoref commented Jan 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsoref commented Jan 25, 2024

ytmimi commented Jan 25, 2024

ytmimi left a comment

Choose a reason for hiding this comment

calebcartwright commented Jun 19, 2023 •

edited

Loading