-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #5753
Spelling #5753
Changes from all commits
7b3ab3d
1ffd8fc
b5e2bd4
8d06ab4
a4f9edb
4c98226
6106ba9
64d2790
d117add
1746baa
561495e
5a2a281
4a45e93
a839a59
9702b45
16193c5
b59d77f
caf9aab
62dd5f2
ce555ad
11c902b
a69d07c
2781afc
ef9e1c6
8a26a30
9e6444f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,7 +27,7 @@ | |
} | ||
``` | ||
- Prevent ICE when formatting `vec!{}` [#5735](https://github.com/rust-lang/rustfmt/issues/5735) | ||
- Prevent internal trailing whitespace error when formatting an empty `macro_rules!` defintion e.g. `macro_rules! foo {}` [#5882](https://github.com/rust-lang/rustfmt/issues/5882) | ||
- Prevent internal trailing whitespace error when formatting an empty `macro_rules!` definition e.g. `macro_rules! foo {}` [#5882](https://github.com/rust-lang/rustfmt/issues/5882) | ||
- Formatting doc comment lines that start with `.` or `)` won't be treated as ordered markdown lists because `.` or `)` must be preceded by a number to start an ordered markdown list [#5835](https://github.com/rust-lang/rustfmt/pull/5835) | ||
- Add parenthesis around closures when they're used as method receives, don't have a block body, and end with `.` [#4808](https://github.com/rust-lang/rustfmt/issues/4808) | ||
```rust | ||
|
@@ -184,7 +184,7 @@ | |
|
||
- Simplify the rustfmt help text by eliding the full path to the rustfmt binary path from the usage string when running `rustfmt --help` [#5214](https://github.com/rust-lang/rustfmt/issues/5214) | ||
|
||
- Bumped the version for serveral dependencies. Most notably `dirs` `v2.0.1` -> `v4.0.0`. This changed the global user config directory on macOS from `$HOME/Library/Preferences` to `$HOME/Library/Application Support` [#5237](https://github.com/rust-lang/rustfmt/pull/5237) | ||
- Bumped the version for several dependencies. Most notably `dirs` `v2.0.1` -> `v4.0.0`. This changed the global user config directory on macOS from `$HOME/Library/Preferences` to `$HOME/Library/Application Support` [#5237](https://github.com/rust-lang/rustfmt/pull/5237) | ||
|
||
### Fixed | ||
|
||
|
@@ -942,7 +942,7 @@ from formatting an attribute #3665 | |
|
||
### Fixed | ||
|
||
- Do not remove path disambiugator inside macro #3142 | ||
- Do not remove path disambiguator inside macro #3142 | ||
- Improve handling of Windows newlines #3141 | ||
- Fix alignment of a struct's fields (`struct_field_align_threshold` option) with the Visual `indent_style` #3165 | ||
- Fix a bug in formatting markdown lists within comments #3172 | ||
|
@@ -1031,7 +1031,7 @@ from formatting an attribute #3665 | |
|
||
### Changed | ||
|
||
- Replace '--conifig-help' with '--config=help' cb10e06 | ||
- Replace '--config-help' with '--config=help' cb10e06 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's possible this means what it said, but I'm guessing it didn't. |
||
- Improve formatting of slice patterns #2912 | ||
|
||
### Fixed | ||
|
@@ -1075,7 +1075,7 @@ from formatting an attribute #3665 | |
- Add max_width option for all heuristics c2ae39e | ||
- Add config option `format_macro_matchers` to format the metavariable matching patterns in macros 79c5ee8 | ||
- Add config option `format_macro_bodies` to format the bodies of macros 79c5ee8 | ||
- Format exitential type fc307ff | ||
- Format existential type fc307ff | ||
- Support raw identifiers in struct expressions f121b1a | ||
- Format Async block and async function 0b25f60 | ||
|
||
|
@@ -1131,7 +1131,7 @@ from formatting an attribute #3665 | |
|
||
### Changed | ||
|
||
- Update rustc-ap-syntax to 128.0.0 and ustc-ap-rustc_target to 128.0.0 195395f | ||
- Update rustc-ap-syntax to 128.0.0 and rustc-ap-rustc_target to 128.0.0 195395f | ||
- Put operands on its own line when each fits in a single line f8439ce | ||
- Improve CLI options 55ac062 1869888 798bffb 4d9de48 eca7796 8396da1 5d9f5aa | ||
|
||
|
@@ -1195,7 +1195,7 @@ from formatting an attribute #3665 | |
- Do not collapse block around expr with condition on match arm 5b9b7d5 | ||
- Use vertical layout for complex attributes c77708f | ||
- Format array using heuristics for function calls 98c6f7b | ||
- Implement stable ordering for impl items with the the following item priority: type, const, macro, then method fa80ddf | ||
- Implement stable ordering for impl items with the following item priority: type, const, macro, then method fa80ddf | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Doubled words aren't technically misspellings, but spell checkers have traditionally flagged them as well |
||
- Reorder imports by default 164cf7d | ||
- Group `extern crate` by default 3a138a2 | ||
- Make `error_on_line_overflow` false by default f146711 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ | |
- Open Rustfmt settings (File → Settings → Languages & Frameworks → Rust → Rustfmt) and enable "Run rustfmt on Save" | ||
![run_rustfmt_on_save](https://user-images.githubusercontent.com/6505554/83944610-3468f380-a81e-11ea-9c34-0cbd18dd4969.png) | ||
|
||
- IntellJ uses autosave, so now your files will always be formatted according to rustfmt. Alternatively you can use Ctrl+S to reformat file manually | ||
- IntelliJ uses autosave, so now your files will always be formatted according to rustfmt. Alternatively you can use Ctrl+S to reformat file manually | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. brand |
||
|
||
### Bind shortcut to "Reformat File with Rustfmt" action | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,7 @@ impl ConfigType for IgnoreList { | |
} | ||
|
||
macro_rules! create_config { | ||
// Options passed in to the macro. | ||
// Options passed into the macro. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
// | ||
// - $i: the ident name of the option | ||
// - $ty: the type of the option value | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -339,10 +339,10 @@ fn flatten_arm_body<'a>( | |
(true, body) | ||
} | ||
} else { | ||
let cond_becomes_muti_line = opt_shape | ||
let cond_becomes_multi_line = opt_shape | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. elsewhere, |
||
.and_then(|shape| rewrite_cond(context, expr, shape)) | ||
.map_or(false, |cond| cond.contains('\n')); | ||
if cond_becomes_muti_line { | ||
if cond_becomes_multi_line { | ||
(false, &*body) | ||
} else { | ||
(can_extend(expr), &*expr) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some projects don't like changing change logs. Happy to drop.