-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Linux binaries in an old CentOS 5 image #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help the binaries be maximally compatible with older Linux releases as they'll depend on a very old glibc. This also touches up the linkage to openssl to be static on Linux and dynamic on OSX. The docker image used here is currently the same one that we're using in rust-lang/rust for the production of the nightly compilers.
It also looks like this doesn't slow down the CI all that much as well! |
Diggsey
added a commit
that referenced
this pull request
Oct 28, 2015
Build Linux binaries in an old CentOS 5 image
Awesome! I seem to spend ages fiddling with the CI build scripts, so I'm very glad I didn't have to figure this one out 😛 |
djc
added a commit
that referenced
this pull request
Jun 18, 2024
# This is the 1st commit message: Port cli_inst_interactive to CliTestContext # The commit message #2 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #3 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #4 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #5 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #6 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #7 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #8 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #9 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #10 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #11 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #12 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #13 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #14 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #15 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #16 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #17 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #18 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #19 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #20 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #21 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #22 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #23 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #24 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #25 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #26 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #27 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #28 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #29 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #30 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #31 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #32 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #33 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #34 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #35 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #36 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #37 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #38 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #39 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext # The commit message #40 will be skipped: # fixup! Port cli_inst_interactive to CliTestContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help the binaries be maximally compatible with older Linux releases
as they'll depend on a very old glibc. This also touches up the linkage to
openssl to be static on Linux and dynamic on OSX.
The docker image used here is currently the same one that we're using in
rust-lang/rust for the production of the nightly compilers.