ndk-build: Use LLVM binutils when GNU binutils are removed (r23+) #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Mar 26, 2021
MarijnS95
force-pushed
the
ndk-r23-llvm-binutils
branch
from
21f5dbb
to
6af6868
Compare
Since [r21] LLVM binutils are included _for testing_; Since [r22] GNU binutils are deprecated in favour of LLVM's; Since [r23] GNU binutils have been removed. When GNU binutils are not available (`<triple>-<bin_name>`) "fall back" to `llvm-<bin_name>` binaries from LLVM binutils that are now included with the NDK. To maintain stability with the current ndk-build crate release, prefer GNU binutils for as long as it is provided by the NDK instead of trying to use `llvm-<bin_name>` from r21 onwards. [r21]: https://github.com/android/ndk/wiki/Changelog-r21 [r22]: https://github.com/android/ndk/wiki/Changelog-r22 [r23]: https://github.com/android/ndk/wiki/Changelog-r23 Fixes rust-mobile#135
MarijnS95
force-pushed
the
ndk-r23-llvm-binutils
branch
from
6af6868
to
af2da04
Compare
msiglreith
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since r21 LLVM binutils are included for testing;
Since r22 GNU binutils are deprecated in favour of LLVM's;
Since r23 GNU binutils have been removed.
When GNU binutils are not available (
<triple>-<bin_name>) "fall back" tollvm-<bin_name>binaries from LLVM binutils that are now included with the NDK.To maintain stability with the current ndk-build crate release, prefer GNU binutils for as long as it is provided by the NDK instead of trying to use
llvm-<bin_name>from r21 onwards.Fixes #135
We could also opt for LLVM binutils in r22 (requires extra logic to figure out whether we're building on r21 or r22) where GNU binutils are technically deprecated, but since the current crate release already uses that successfully there seems no need to change it at risk of breaking projects that are somehow incompatible.