Add portable simd (core::simd) implementation #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licenser
force-pushed
the
portable-simd
branch
2 times, most recently
from
0c29ff5
to
9dabd18
Compare
hkratz
force-pushed
the
portable-simd
branch
from
9dabd18
to
4853446
Compare
|
@Licenser Sorry for being unresponsive for the last year. Now I am finally picking up on this. I hope you don't mind me fixing it up a bit before merging. |
|
Hey, no worries, I've been doing OSS for long enough to have all the understanding in the world for things taking time :) |
Signed-off-by: Heinz N. Gies <[email protected]>
hkratz
force-pushed
the
portable-simd
branch
from
33559d8
to
7f72048
Compare
# Conflicts: # src/implementation/mod.rs # tests/tests.rs
This reverts commit c01f0a7.
…able_override features
|
@Licenser Using a 128-bit wide portable simd implementation is only a few percent slower on ARM64 than the implementation using native intrinsics:
|
|
That's pretty neat! |
|
@Licenser I will be merging this but I might create an experimental |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds experimental 128- and 256-bit
core::simd(rusts portable simd) implementations. Since portable simd is a nightly-only feature, it is guarded behind theportable_public_impfeature flag. The implementations are accessible via thesimdutf8::basic::imp::portable::simd128andsimdutf8::basic::imp::portable::simd256modules.