-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native impls #328
Merged
Merged
Native impls #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darach
reviewed
Oct 19, 2023
this requires rusticstuff/simdutf8#83 to be merged and released to, we depend on simdutf8 for string validation |
Licenser
force-pushed
the
native-impl
branch
5 times, most recently
from
October 20, 2023 09:10
d7ababa
to
dce3288
Compare
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Licenser
force-pushed
the
native-impl
branch
3 times, most recently
from
October 20, 2023 10:52
360cc04
to
fd6f72f
Compare
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Signed-off-by: Heinz N. Gies <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a native implementation that can act as a fallback for platforms that do not support any of the implemented architectures.
As a addition, it adds a
std::simd
implementation that would allow for native (but possibly not as optimized) simd on any platform that supports rust, but since this feature is a nightly feature, it is guarded behind theportable
feature flag