Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Something wrong with 3270 letter "small m"? #947

Closed
arkenoi opened this issue Sep 29, 2022 · 10 comments · Fixed by #948
Closed

Something wrong with 3270 letter "small m"? #947

arkenoi opened this issue Sep 29, 2022 · 10 comments · Fixed by #948
Labels
confirmed

Comments

@arkenoi
Copy link

arkenoi commented Sep 29, 2022

🗹 Requirements

🔧 Your Setup

Affects the whole 3270 font family, and rendering is the same in all applications.

I use Linux (Fedora 36 template under Qubes OS 4.1)

★ Screenshots (Optional)

2022-09-29-121040
@arkenoi
Copy link
Author

arkenoi commented Sep 29, 2022

Just cross-checked if non-gnome apps are affected. Yes, they are.

@Finii
Copy link
Collaborator

Finii commented Sep 29, 2022

Thanks for the report. Checking now..

@Finii
Copy link
Collaborator

Finii commented Sep 29, 2022

Hmm, only otf is affected?!

image

@Finii
Copy link
Collaborator

Finii commented Sep 29, 2022

WAT?!

image

@Finii
Copy link
Collaborator

Finii commented Sep 29, 2022

This seems to be a fontforge problem:

image

Happens with March 2022 release, but not with March 2020 release (of fontforge). Hmm.

@Finii
Copy link
Collaborator

Finii commented Sep 29, 2022

All the ff code around the error message is old. This will take some time to fix in ff:

image

@Finii
Copy link
Collaborator

Finii commented Sep 29, 2022

The corruption already occurs when merely opening the file.

@Finii
Copy link
Collaborator

Finii commented Sep 29, 2022

Bisected to

image

This PR fontforge/fontforge#4685

Finii added a commit that referenced this issue Sep 29, 2022
@Finii
Update 3270font to v3.0.1
db6518c 
[why]
We have only a rather old 3270font: v1.2.23

This new font can be processed with current FontForge without problems.
And we have the benefit of an update.

[how]
Because the paths change (Medium->Regular etc) we need to purge the
patched-fonts/ directories manually. The automatic purging does work
only if at least the paths are kept.

[note]
https://github.com/rbanffy/3270font

Fixes: #947

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii mentioned this issue Sep 29, 2022
Merged
2 tasks
@Finii
Copy link
Collaborator

Finii commented Sep 29, 2022

We can fix this for us by just updating the font. The current version has no problems as far as I can see.
In this way I can avoid to debug fontforge 😬

The patch results can be downloaded here (for trials):
https://github.com/Finii/nerd-fonts/tree/feature/update-3270font-patched/patched-fonts/3270

Finii added a commit that referenced this issue Oct 7, 2022
@Finii
Update 3270font to v3.0.1
c67311f 
[why]
We have only a rather old 3270font: v1.2.23

This new font can be processed with current FontForge without problems.
And we have the benefit of an update.

[how]
Because the paths change (Medium->Regular etc) we need to purge the
patched-fonts/ directories manually. The automatic purging does work
only if at least the paths are kept.

[note]
https://github.com/rbanffy/3270font

Fixes: #947

Signed-off-by: Fini Jastrow <[email protected]>
@Finii Finii closed this as completed in #948 Oct 7, 2022
Finii added a commit that referenced this issue Oct 7, 2022
@Finii
Update 3270font to v3.0.1
ed33d1b 
[why]
We have only a rather old 3270font: v1.2.23

This new font can be processed with current FontForge without problems.
And we have the benefit of an update.

[how]
Because the paths change (Medium->Regular etc) we need to purge the
patched-fonts/ directories manually. The automatic purging does work
only if at least the paths are kept.

[note]
https://github.com/rbanffy/3270font

Fixes: #947

Signed-off-by: Fini Jastrow <[email protected]>
@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update 3270font to v3.0.1 ryanoasis/nerd-fonts
2 participants
@arkenoi @Finii