Update 3270font to v3.0.1 #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch-reults can be examined here: |
|
This needs a CI |
[why] We have only a rather old 3270font: v1.2.23 This new font can be processed with current FontForge without problems. And we have the benefit of an update. [how] Because the paths change (Medium->Regular etc) we need to purge the patched-fonts/ directories manually. The automatic purging does work only if at least the paths are kept. [note] https://github.com/rbanffy/3270font Fixes: #947 Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
feature/update-3270font
branch
from
db6518c
to
c67311f
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[why]
We have only a rather old 3270font: v1.2.23
This new font can be processed with current FontForge without problems. And we have the benefit of an update.
[how]
Because the paths change (Medium->Regular etc) we need to purge the patched-fonts/ directories manually. The automatic purging does work only if at least the paths are kept.
[note]
https://github.com/rbanffy/3270font
Fixes: #947
Requirements / Checklist
What does this Pull Request (PR) do?
Update 3270 to latest version, thereby fixing
fontforgeproblem (see Issue).How should this be manually tested?
Have a look on the produced 3270 fonts, both ttf and otf.
Any background context you can provide?
See Fontforge problem mentioned in #947 (comment)
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)