Sass & Class Renames #759
Merged
Sass & Class Renames #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 16, 2019 18:53
- add cssnano - add postcss-loader - remove unused packages
added 10 commits
February 17, 2019 08:51
- move spinner to scss module
…slot, you might not want default styles
|
@stevenharman @eriknygren would really appreciate any thoughts either of you have on this one – it's a big change. |
added 6 commits
February 17, 2019 13:51
- rename dropdownClasses to stateClasses
added 12 commits
February 18, 2019 10:42
Codecov Report
@@ Coverage Diff @@
## release/v3.0 #759 +/- ##
===============================================
Coverage ? 88.29%
===============================================
Files ? 4
Lines ? 205
Branches ? 56
===============================================
Hits ? 181
Misses ? 12
Partials ? 12
Continue to review full report at Codecov.
|
Happy to hear it! Thanks for your effort |
sagalbot
pushed a commit
that referenced
this pull request
Apr 14, 2019
* origin/release/v3.0: (67 commits) ensure #222 stays closed (#828) add guide for reduce and taggable (#827) Remove foo bar (#826) WIP: v3 – remove onSearch callback prop (#811) doc content updates overhaul selecting docs, updated navigation and URL structure bump vue-server-renderer (#807) WIP: V3 - Remove index prop, add reduce prop (#800) V3/update list items slot (#799) update vuepress (#797) Update sandbox Add patch from #787 update package deps, remove extra dev options V3 - Remove `mutable` class properties plus other misc changes (#781) refactor deselect method (#768) Sass & Class Renames (#759) fix coveralls coverage reporter (#766) remove: - express - gitbook - json-loader - markdown-loader - normalize.css - prismjs - vue-resource use test-utils beta-20 fix failing test ... # Conflicts: # docs/gitbook/README.md # docs/homepage/home.html # src/components/Select.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
!defaultscss variables prepended with$vs-loadingboolean propEnhancements
Refined selectors to use a single level of specificity, expect when global component states like
vs--searchingare involved. The refined selectors shave~2.5kboff the build, and removes a lot of friction when attempting to override component styles.Changes
selected-tagclass renamed tovs__selectionvs__prefixex)
.v-select .selected-tagbecomes.vs__selectionv3draft release notesdropdownandrtlclasses from elul > li > astructure by removing unnecessarya, refactor all selectors to use.vs__dropdown-optiondropdownClasses()renamed tocomponentState()vs--maxHeightprop, control via CSSCloses #574 #662 #677 #535 #468
Related #596 #451 #447