-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 - Remove mutable
class properties plus other misc changes
#781
Merged
sagalbot
merged 16 commits into
sagalbot:release/v3.0
from
owenconti:ft/remove-mutableValue
Mar 23, 2019
Merged
V3 - Remove mutable
class properties plus other misc changes
#781
sagalbot
merged 16 commits into
sagalbot:release/v3.0
from
owenconti:ft/remove-mutableValue
Mar 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagalbot
reviewed
Mar 10, 2019
sagalbot
reviewed
Mar 11, 2019
owenconti
commented
Mar 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the onInput
prop and replaced with a method: updateValue
sagalbot
reviewed
Mar 11, 2019
Huge thanks for this one @owenconti I think it's a big improvement! |
sagalbot
pushed a commit
that referenced
this pull request
Apr 14, 2019
* origin/release/v3.0: (67 commits) ensure #222 stays closed (#828) add guide for reduce and taggable (#827) Remove foo bar (#826) WIP: v3 – remove onSearch callback prop (#811) doc content updates overhaul selecting docs, updated navigation and URL structure bump vue-server-renderer (#807) WIP: V3 - Remove index prop, add reduce prop (#800) V3/update list items slot (#799) update vuepress (#797) Update sandbox Add patch from #787 update package deps, remove extra dev options V3 - Remove `mutable` class properties plus other misc changes (#781) refactor deselect method (#768) Sass & Class Renames (#759) fix coveralls coverage reporter (#766) remove: - express - gitbook - json-loader - markdown-loader - normalize.css - prismjs - vue-resource use test-utils beta-20 fix failing test ... # Conflicts: # docs/gitbook/README.md # docs/homepage/home.html # src/components/Select.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lot's of stuff here, apologies for the large size. I can break pieces out to individual PRs if needed.
I'll try to summarize the changes:
Select component
mutableValue
andmutableOptions
in hopes of simpler and less code inSelect.vue
mutableValue
andmutableOptions
:selectedValue
andoptionList
selectedValue
is always an array (regardless of themultiple
prop). This makes working with it easier because we'll always know the typeoptionList
is the combination of theoptions
prop plus any pushed tagsTests:
value
is passed, most of the tests were updated to not pass avalue
prop. By not passing avalue
prop, vue-select knows it has to manage the selected value internally. There is aninternalValue
data value which is used to manage the internal value (very much likemutableValue
was before, onlyinternalValue
is only used in two places)Dev sandbox:
v-model
,:value
with@input
, and no value (managed internally).