Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> #36452 broke `make SPKG-uninstall` for Python packages. Reproducer: ``` $ make zipp-uninstall ... if [ -d '/Users/mkoeppe/s/sage/sage-rebasing/worktree- clean/local/var/lib/sage/venv-python3.10' ]; then sage-spkg-uninstall zipp '/Users/mkoeppe/s/sage/sage-rebasing/worktree- clean/local/var/lib/sage/venv-python3.10'; fi Uninstalling existing 'zipp' Running pip-uninstall script for 'zipp' ERROR: Could not open requirements file: [Errno 2] No such file or directory: '/Users/mkoeppe/s/sage/sage-rebasing/worktree- clean/local/var/lib/sage/venv-python3.10/var/lib/sage/scripts/zipp/spkg- requirements.txt' Warning: pip exited with status 0 Removing stamp file '/Users/mkoeppe/s/sage/sage-rebasing/worktree- clean/local/var/lib/sage/venv- python3.10/var/lib/sage/installed/zipp-3.11.0' $ ./sage -pip list | grep zipp zipp 3.11.0 ``` <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #36737 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
- Loading branch information