Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move create_RealField to real_field.py #24511

Closed
rwst opened this issue Jan 11, 2018 · 18 comments
Closed

Move create_RealField to real_field.py #24511

rwst opened this issue Jan 11, 2018 · 18 comments
Labels
c: basic arithmetic p: minor / 4 t: enhancement
Milestone
sage-8.3

Comments

@rwst
Copy link

rwst commented Jan 11, 2018

This is part of #24457 but it already makes sense without that ticket to have the factory function in a separate module.

CC: @videlec

Component: basic arithmetic

Author: Ralf Stephan

Branch/Commit: c02bb43

Reviewer: Vincent Delecroix

Issue created by migration from https://trac.sagemath.org/ticket/24511
@rwst rwst added this to the sage-8.2 milestone Jan 11, 2018
@rwst
Copy link
Author

rwst commented Jan 11, 2018

Branch: u/rws/24511

@rwst
Copy link
Author

rwst commented Jan 11, 2018

Author: Ralf Stephan

@rwst
Copy link
Author

rwst commented Jan 11, 2018

New commits:

a78229624511: Move create_RealField to real_field.py

@rwst
Copy link
Author

rwst commented Jan 11, 2018

Commit: a782296

@videlec
Copy link
Contributor

videlec commented Jan 11, 2018

Reviewer: Vincent Delecroix

@videlec
Copy link
Contributor

videlec commented Jan 11, 2018

comment:5

Needs deprecation in sage.rings.real_mpfr (and doctest).

@rwst
Copy link
Author

rwst commented Jan 11, 2018

Dependencies: #24515

@rwst
Copy link
Author

rwst commented Jan 11, 2018

comment:7

For that please see #24515.

@videlec
Copy link
Contributor

videlec commented Jan 11, 2018

comment:8

deprecation does not necessit lazy import

def create_RealField(*args, **kwds):
    r"""
    Depreacted function moved to :mod:`sage.rings.real_field`
    """
    from sage.misc.superseded import deprecation
    deprecation(24511, "do not import from here")
    from sage.rings.real_field import create_RealField as the_good_one
    return the_good_one(*args, **kwds)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

977f62d24511 deprecation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 11, 2018

Changed commit from a782296 to 977f62d

@videlec
Copy link
Contributor

videlec commented Jan 11, 2018

comment:11

Looks good. Just waiting for a patchbot report for doctest coverage.

@videlec
Copy link
Contributor

videlec commented Jan 18, 2018

comment:13

merge failure in src/sage/rings/integer_ring.pyx with 8.2.beta3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2018

Changed commit from 977f62d to c02bb43

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 18, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

c02bb43Merge branch 'develop' into t/24511/24511

@loefflerd loefflerd mannequin modified the milestones: sage-8.2, sage-8.3 May 17, 2018
@vbraun
Copy link
Member

vbraun commented May 28, 2018

Changed dependencies from #24515 to none

@vbraun
Copy link
Member

vbraun commented May 28, 2018

comment:18

PS: You don't get merged if depend on a ticket that is not merged (even if its closed as duplicate)

@vbraun
Copy link
Member

vbraun commented May 30, 2018

Changed branch from u/rws/24511 to c02bb43

@vbraun vbraun closed this as completed in 4c2e232 May 30, 2018
@videlec videlec mentioned this issue Dec 29, 2022
Open
mkoeppe added a commit to mkoeppe/sage that referenced this issue Sep 21, 2023
@mkoeppe
src/sage/rings/real_mpfr.pyx: Remove function deprecated in sagemath#…
56181f5 
…24511 (2018)
vbraun pushed a commit to vbraun/sage that referenced this issue Sep 23, 2023
sagemathgh-36307: sage.rings: Remove code deprecated in sagemath#23204
9ea5127 
, sagemath#24483, sagemath#24371, sagemath#24511, sagemath#25848, sagemath#26105, sagemath#28481, sagemath#29010, sagemath#29412, sagemath#30332, sagemath#30372, sagemath#31345, sagemath#32375, sagemath#32606, sagemath#32610, sagemath#32612, sagemath#32641, sagemath#32660, sagemath#32750, sagemath#32869, sagemath#33602

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36307
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: basic arithmetic p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-8.3
Development

No branches or pull requests
3 participants
@vbraun @rwst @videlec