-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sage_wraps by decorator library #30884
Comments
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
Functions such as |
comment:5
Good to know! I've readded and marked as deprecated them. This should be now ready for review. |
Changed work issues from Fix patchbot warnings to none |
comment:8
Better squash changes like this so that |
comment:9
Does the |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Work Issues: Fix patchbot warnings |
comment:15
Can you explain the purpose of the change diff --git a/src/sage_setup/docbuild/__init__.py b/src/sage_setup/docbuild/__init__.py
index b07e9c1..a4ba68e 100644
--- a/src/sage_setup/docbuild/__init__.py
+++ b/src/sage_setup/docbuild/__init__.py
@@ -564,7 +564,7 @@ class ReferenceBuilder(AllBuilder):
if not os.path.exists(refdir):
continue
logger.info('Building bibliography')
- self._build_bibliography(lang, format, *args, **kwds)
+ #self._build_bibliography(lang, format, *args, **kwds)
logger.info('Bibliography finished, building dependent manuals')
self._build_everything_except_bibliography(lang, format, *args, **kwds)
# The html refman must be build at the end to ensure correct ? |
comment:23
What's the status of this ticket? Just came across a |
comment:25
It is working in principle, but I still need to fix a few things here and there. The biggest problem is that there are some changes to cython files needed, for which it would be really handy if we could get #30371 merged. |
comment:26
Setting new milestone based on a cursory review of ticket status, priority, and last modification date. |
comment:27
Setting a new milestone for this ticket based on a cursory review. |
Changed work issues from Fix patchbot warnings to Wait for micheles/decorator#137 to be merged and released, update decorator lib, x patchbot warnings |
Dependencies: #26254 |
Changed work issues from Wait for micheles/decorator#137 to be merged and released, update decorator lib, x patchbot warnings to Fix patchbot warnings |
Branch pushed to git repo; I updated commit sha1. New commits:
|
This comment has been minimized.
This comment has been minimized.
We rebase `sage_autodoc` to Sphinx 5.3.0. This is a step toward eventual removal of sage_autodoc in sagemath#30893, a customization of Sphinx autodoc extension for Sage objects. Other related tickets are sagemath#27578. sagemath#30884, sagemath#31309, in this regard. URL: https://trac.sagemath.org/34730 Reported by: klee Ticket author(s): Kwankyu Lee Reviewer(s): Tobias Diez
Replace the sage custom sage_wrap and decorator_defaults methods by the well-maintained decorator library https://github.com/micheles/decorator.
My motivation is to replace sage's autodoc sphinx extension with the built-in one. For this, the Phyton introspection code needs to work without sage's customization. This ticket is a first step towards this goal. But independently of this motivation the approach using decorator library already provides cleaner code and better introspection results with respect to annotations (e.g. typing information). See the following test script for a comparison:
Replacing
sage_getargspec
withinspect.getfullargspec
will be done in a follow-up ticket (as this is already big enough).Todo (as follow-up): Migrate cachefunction etc to decorator framework. The documentation https://github.com/micheles/decorator/blob/master/docs/documentation.md#the-solution contains an example (memoize) of how this may look like.
Depends on #26254
CC: @mkoeppe @kwankyu
Component: doctest framework
Work Issues: Fix patchbot warnings
Author: Tobias Diez
Branch/Commit: public/documentation/replaceDecorator @
1b656a3
Issue created by migration from https://trac.sagemath.org/ticket/30884
The text was updated successfully, but these errors were encountered: