Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket CI #33294

Closed
vbraun opened this issue Feb 5, 2022 · 27 comments
Closed

Ticket CI #33294

vbraun opened this issue Feb 5, 2022 · 27 comments

Comments

@vbraun
Copy link
Member

vbraun commented Feb 5, 2022

The aim of this ticket is to:

  • add CI that runs on each ticket (using github actions)
  • use self-hosted runner that is fast enough to build all tickets from scratch
  • prevents tickets from being merged unless it succeeds
  • add status badge to trac

The code from trac ticket will be pushed by an external script to a branch ticket/12345, and this will trigger the CI run.

Example runs: https://github.com/vbraun/sage/actions/workflows/ticket.yaml

Component: build

Branch/Commit: u/vbraun/33294-ticket-ci @ 50d9277

Issue created by migration from https://trac.sagemath.org/ticket/33294

@vbraun vbraun added this to the sage-9.6 milestone Feb 5, 2022
@vbraun
Copy link
Member Author

vbraun commented Feb 5, 2022

Branch: u/vbraun/33294-ticket-ci

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 5, 2022

Commit: b84bce7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 5, 2022

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

011b9c4Trac #33174: Unreachable code in sage/graphs/base/c_graph.pyx
a584ff4Trac #33186: fix some Cython warnings in padics.
053e2d0Trac #33186: Fix "referenced before assignment" warnings in padics
e3f08e8Trac #33193: redeclare val_unit() in padic subclasses that override it.
a8f598eTrac #33193: Fix Cython incompatible redefinition warnings in padics
4f4ae57Trac #33208: remove dead code in sage/rings/padics/pow_computer_ext.pyx.
7935ebcTrac #33208: Remove unused code from sage/rings/padics/pow_computer_ext.pyx
b0fcca3Trac #33210: fix uninitialized pointer use in polynomial_modn_dense_ntl.pyx.
e1c128fTrac #33210: Fix Cython warnings in sage.rings.polynomial.polynomial_modn_dense_ntl
b84bce7WIP

@vbraun

This comment has been minimized.

@vbraun

This comment has been minimized.

@tobiasdiez
Copy link
Contributor

comment:5

Just as a heads-up: something similar is done in #33263 (already ready for merge)

@mkoeppe
Copy link
Member

mkoeppe commented Feb 5, 2022

comment:6

+1 on providing fast self-hosted runners if you have them

-1 on designing workflows that only can succeed on self-hosted runners

(I haven't looked at the yml)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2022

Changed commit from b84bce7 to 7fb096b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7fb096bWIP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2226a67WIP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2022

Changed commit from 7fb096b to 2226a67

@vbraun
Copy link
Member Author

vbraun commented Feb 6, 2022

comment:9

Full (not incremental) build + html docs + long tests takes about 50 mins

There are necessarily going to be some differences with a self-hosted runner, like

  • No docker
  • Use local fs cache (ccache and /upstream)
    but what can be shared should, of course.

@mkoeppe
Copy link
Member

mkoeppe commented Feb 6, 2022

comment:10

I'd suggest to put the script that provisions the runner next to the yml script, to eliminate the guesswork what may be installed on the runner.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 17, 2022

Changed commit from 2226a67 to cb919b0

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 17, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

cb919b0WIP

@mkoeppe
Copy link
Member

mkoeppe commented Feb 17, 2022

Replying to @vbraun:

The code from trac ticket will be pushed by an external script to a branch ticket/12345, and this will trigger the CI run.

https://github.com/sagemath/sagetrac-mirror already has all trac branches. Do you have a script already that would push branches that merge the trac branch into the current beta?
(related - #33113 comment:18)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a38371eWIP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 20, 2022

Changed commit from cb919b0 to a38371e

@vbraun
Copy link
Member Author

vbraun commented Feb 20, 2022

comment:14

I'm working on a script to push the merged tickets to branches named ticket/12354, currently on https://github.com/vbraun/sage until I have worked out the kinks

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2022

Changed commit from a38371e to 0d27d69

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 8, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0d27d69WIP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

f6ada84WIP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 27, 2022

Changed commit from 0d27d69 to f6ada84

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 3, 2022
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 30, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

7c6aed7WIP

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 30, 2022

Changed commit from f6ada84 to 7c6aed7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2022

Changed commit from 7c6aed7 to 50d9277

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 8, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

50d9277WIP

@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants