-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modularization of sagelib: Distributions sagemath-{brial,combinat,eclib,flint,gap,giac,glpk,graphs,groups,homfly,lcalc,libbraiding,libecm,linbox,modules,mpmath,ntl,pari,plot,polyhedra,schemes,singular,standard-no-symbolics,symbolics} #35095
base: develop
Are you sure you want to change the base?
Modularization of sagelib: Distributions sagemath-{brial,combinat,eclib,flint,gap,giac,glpk,graphs,groups,homfly,lcalc,libbraiding,libecm,linbox,modules,mpmath,ntl,pari,plot,polyhedra,schemes,singular,standard-no-symbolics,symbolics} #35095
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #35095 +/- ##
===========================================
- Coverage 88.62% 87.40% -1.22%
===========================================
Files 2148 2180 +32
Lines 398855 399144 +289
===========================================
- Hits 353480 348878 -4602
- Misses 45375 50266 +4891
... and 283 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ee6eb49
to
d368b6e
Compare
I ran
after full rebuild on macOS monterey, and got [37/54] gcc -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -I./sage/cpython -I/private/var/folders/td/fw1q9ljs311ggyph77rs53_40000gn/T/pip-build-env-_on11jf5/overlay/lib/python3.11/site-packages/gmpy2 -I./sage/rings -I/private/var/folders/td/fw1q9ljs311ggyph77rs53_40000gn/T/pip-build-env-_on11jf5/overlay/lib/python3.11/site-packages -I/usr/local/opt/[email protected]/Frameworks/Python.framework/Versions/3.11/include/python3.11 -Ibuild/cythonized -I/Users/kwankyu/GitHub/sage-dev/pkgs/sagemath-polyhedra/.tox/.pkg/include -I/usr/local/opt/[email protected]/Frameworks/Python.framework/Versions/3.11/include/python3.11 -c build/cythonized/sage/structure/coerce.c -o build/temp.macosx-12-x86_64-cpython-311/build/cythonized/sage/structure/coerce.o -fno-strict-aliasing -DCYTHON_CLINE_IN_TRACEBACK=1
build/cythonized/sage/structure/coerce.c:779:10: fatal error: 'gmp.h' file not found
#include "gmp.h"
^~~~~~~
1 error generated. |
I've updated the instructions for testing. |
|
Is this on macOS with homebrew? DId you run .homebrew-build-env? |
Yes. My bash profile does I manually pasted the line and tried again. But I got the same. |
I am trying again after deleting |
I got the same failure. Part of the log
|
Have you tried the command |
No. Shall I? |
Yes, that's what I would recommend as the best way of testing |
I ran
|
Could you try if |
I ran |
Could you check the contents of |
|
The |
Part of the log:
|
It says |
This reverts commit d4196d7.
…s from pyproject.toml
…ect] dependencies, [project.optional-dependencies] too
…package names, treat dashes and underscores as equivalent
…ted from src/pyproject.toml
…b__break_out_a_separate_package_sagemath_polyhedra
…eds` <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Also some doctest cosmetics. - Cherry-picked from sagemath#35095. `sage --fixdoctests --verbose` now shows doctest tagging statistics. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38118 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> - Cherry-picked from sagemath#35095. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38142 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Some of these are from the use of a matrix norm, which `# needs scipy`. Also a norm-related change in `sage.modules.free_module_integer` - avoiding use of `norm`, which send us into symbolics land, in favor of just comparing norm squares - Cherry-picked from sagemath#35095. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38236 Reported by: Matthias Köppe Reviewer(s): David Coudert
…lib__break_out_a_separate_package_sagemath_polyhedra
📚 Description
📝 Checklist
⌛ Dependencies
fast_callable
interpreters #35774sage.functions
: Decouple fromsage.symbolic.expression
andmpmath
, update# needs
#35716sage.calculus
: Modularization fixes, doctest cosmetics,# needs
#35717pkgs/sagemath-{objects,categories,standard}
: Switch to meson-python build system #37012src/bin/sage-cython
: Repurpose as PEP 420 fixer #37009sage-generate-meson
script to sage-setup #37008# sage_setup: distribution
directives to all files, remove remaining# coding: utf-8
#36964pkgs/sagemath-standard
: Move metadata fromsetup.cfg
topyproject.toml
#36951pkgs/sagemath-{objects,categories}
: Enlarge #36566pyproject.toml
: Add 'external' section according to draft PEP 725 #37486pkgs/sage-conf
: Move metadata fromsetup.cfg
topyproject.toml
#36561pkgs/sagemath-*/setup.py
throughsage_setup.sage_setup
#36649sage.*.all
for modularization, replace relative by absolute imports #36676This is part of: