Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipython 8.18 and related upgrades, remove backcall #36823

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Dec 6, 2023

Upgrading ipython to latest. This is a small upgrade done as a follow-up of #36129, which allows us to drop the backcall package. https://ipython.readthedocs.io/en/stable/whatsnew/version8.html#ipython-8-18-and-8-18-1

The upgrade of pexpect to 4.9 and tornado to 6.4.0 add support for Python 3.12. https://github.com/pexpect/pexpect/releases/tag/4.9, https://www.tornadoweb.org/en/stable/releases/v6.4.0.html

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Dec 6, 2023
@mkoeppe mkoeppe changed the title ipython 8.18 and related upgrades, remove backcall, ipython 8.18 and related upgrades, remove backcall Dec 7, 2023
@jhpalmieri
Copy link
Member

jhpalmieri commented Dec 7, 2023

The pexpect download didn't work for some reason. I got a tarball from https://pypi.org/project/pexpect/#files and the build is continuing.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2023

Thanks, fixed now

Copy link

github-actions bot commented Dec 7, 2023

Documentation preview for this PR (built with commit 5fd53f6; changes) is ready! 🎉

@jhpalmieri
Copy link
Member

Looks good to me, a straightforward package upgrade.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 7, 2023

Thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request Dec 10, 2023
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Upgrading ipython to latest. This is a small upgrade done as a follow-up
of [sagemath#36129](sagemath#36129), which allows
us to drop the `backcall` package. https://ipython.readthedocs.io/en/sta
ble/whatsnew/version8.html#ipython-8-18-and-8-18-1

The upgrade of pexpect to 4.9 and tornado to 6.4.0 add support for
Python 3.12. https://github.com/pexpect/pexpect/releases/tag/4.9,
https://www.tornadoweb.org/en/stable/releases/v6.4.0.html




<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36823
Reported by: Matthias Köppe
Reviewer(s): John H. Palmieri
@vbraun vbraun merged commit 4f34f92 into sagemath:develop Dec 14, 2023
34 of 49 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants