Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModulesWithBasis.ParentMethods.cardinality() for 0 dimensional modules #36985

Merged

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Jan 1, 2024

Currently this is not handled properly as $\infty^0$ is not well-defined but we know a 0 dimensional free module is $\{0\}$ with one element.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

github-actions bot commented Jan 1, 2024

Documentation preview for this PR (built with commit 23bef33; changes) is ready! 🎉

Copy link
Contributor

@darijgr darijgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Simplest review ever.

@tscrim
Copy link
Collaborator Author

tscrim commented Jan 1, 2024

Thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 2, 2024
…dimensional modules

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Currently this is not handled properly as $\infty^0$ is not well-defined
but we know a 0 dimensional free module is $\\{0\\}$ with one element.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

URL: sagemath#36985
Reported by: Travis Scrimshaw
Reviewer(s): Darij Grinberg
vbraun pushed a commit to vbraun/sage that referenced this pull request Jan 5, 2024
…dimensional modules

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Currently this is not handled properly as $\infty^0$ is not well-defined
but we know a 0 dimensional free module is $\\{0\\}$ with one element.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36985
Reported by: Travis Scrimshaw
Reviewer(s): Darij Grinberg
@vbraun vbraun merged commit c6bf497 into sagemath:develop Jan 14, 2024
24 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Jan 14, 2024
@tscrim tscrim deleted the categories/modules_with_basis_cardinality branch January 14, 2024 22:29
vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 24, 2024
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

This provides an implementation of the Specht modules over arbitrary
fields in the standard tableaux basis. To do so, we also implement the
tabloid module, where the tabloids are implemented as
`OrderedSetsPartitions`. Using this, we can construct the maximal
submodule and simple submodule from a Specht module.

We also implement a method to compute the Brauer character of the
representations.

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

- sagemath#36724: Trivial conflict with working on the same files.
- sagemath#36985: So the 0 dimensional tests will pass.

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36748
Reported by: Travis Scrimshaw
Reviewer(s): Darij Grinberg, Frédéric Chapoton, Martin Rubey, Travis Scrimshaw
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants