Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build/pkgs/pytest*: Change to standard wheel packages #37301

Merged
merged 17 commits into from
Aug 3, 2024
Merged

build/pkgs/pytest*: Change to standard wheel packages #37301

merged 17 commits into from
Aug 3, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 12, 2024 •
edited
Loading

Vote: https://groups.google.com/g/sage-devel/c/MIU-xo9b7pc
Vote (redo): https://groups.google.com/g/sage-devel/c/lPLoA7zaoyg

Fixes #31110

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Feb 12, 2024
@mkoeppe mkoeppe force-pushed the pytest_standard branch 2 times, most recently from 7e85345 to 74e7744 Compare February 15, 2024 08:43
@mkoeppe mkoeppe marked this pull request as ready for review February 15, 2024 08:43
@mkoeppe mkoeppe changed the title build/pkgs/pytest*: Change to standard normal packages build/pkgs/pytest*: Change to standard wheel packages Feb 18, 2024
@mkoeppe mkoeppe requested a review from dimpase February 18, 2024 18:20
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2024

@dimpase May I suggest that you take the time to try out this PR? If you want to understand how a "wheel" package (https://deploy-livedoc--sagemath.netlify.app/html/en/developer/packaging#package-source-types) is installed, maybe install using ./sage -i -s pytest and look at what's happening in venv/var/tmp/sage

@dimpase
Copy link
Member

dimpase commented Feb 18, 2024

As I said, I object to endless proliferation of more and more python (wheel - in case of pure python - or source, doesn't really matter) packages in Sage. If these were pip packages it would be possible to avoid bringing 2 more dependencies into Sage

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 18, 2024

As I said, I object

We already know that.

My suggestion above is friendly guidance to a level on which a discussion makes more sense than what's currently happening in https://groups.google.com/g/sage-devel/c/5kmxaw105lg

@mkoeppe mkoeppe force-pushed the pytest_standard branch 2 times, most recently from cdaf8ea to dc79532 Compare April 1, 2024 00:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 52840e0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe removed the pending label Jun 13, 2024
@mkoeppe mkoeppe requested a review from saraedum June 18, 2024 23:32
kwankyu
kwankyu approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Adding two more dependencies for improving testing infrastructure of sage is not a big deal.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 27, 2024

TypeError: call() got an unexpected keyword argument 'warn_on_impl_args'

Confirmed

@kwankyu
Copy link
Collaborator

kwankyu commented Jul 31, 2024

working well now.

kwankyu
kwankyu approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 31, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 2, 2024
sagemathgh-37301: build/pkgs/pytest*: Change to standard wheel pack…
0663a5d 
…ages

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
Vote: https://groups.google.com/g/sage-devel/c/MIU-xo9b7pc
Vote (redo): https://groups.google.com/g/sage-devel/c/lPLoA7zaoyg

Fixes sagemath#31110

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#37301
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 9fb1a15 into sagemath:develop Aug 3, 2024
30 of 39 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Aug 3, 2024
@mkoeppe mkoeppe deleted the pytest_standard branch August 3, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@dimpase dimpase Awaiting requested review from dimpase

@saraedum saraedum Awaiting requested review from saraedum

Assignees

@mkoeppe mkoeppe

Labels
c: packages: standard v: small
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.

Make pytest a standard package
4 participants
@mkoeppe @dimpase @kwankyu @vbraun