Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix: broken livedoc #38082

Merged
merged 1 commit into from
Jun 1, 2024
Merged

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented May 25, 2024

as seen in

https://github.com/sagemath/sage/actions/runs/9234699215/job/25408704331#:~:text=bash%3A%20line%201%3A%20cd%3A%20./worktree%2Dimage%3A%20No%20such%20file%20or%20directory

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Run script in /sage CI fix: broken livedoc May 25, 2024
@kwankyu
Copy link
Collaborator Author

kwankyu commented May 25, 2024

It seems right to copy the line 150:

shell: sh .ci/docker-exec-script.sh BUILD /sage {0}

Am I right? @mkoeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented May 25, 2024

Yes, thanks for fixing this.

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 25, 2024

Thanks!

Copy link

Documentation preview for this PR (built with commit 1680233; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 26, 2024
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

as seen in

https://github.com/sagemath/sage/actions/runs/9234699215/job/25408704331
#:~:text=bash%3A%20line%201%3A%20cd%3A%20./worktree%2Dimage%3A%20No%20su
ch%20file%20or%20directory

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#38082
Reported by: Kwankyu Lee
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 27, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

as seen in

https://github.com/sagemath/sage/actions/runs/9234699215/job/25408704331
#:~:text=bash%3A%20line%201%3A%20cd%3A%20./worktree%2Dimage%3A%20No%20su
ch%20file%20or%20directory

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38082
Reported by: Kwankyu Lee
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 29, 2024
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

as seen in

https://github.com/sagemath/sage/actions/runs/9234699215/job/25408704331
#:~:text=bash%3A%20line%201%3A%20cd%3A%20./worktree%2Dimage%3A%20No%20su
ch%20file%20or%20directory

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38082
Reported by: Kwankyu Lee
Reviewer(s):
@vbraun vbraun merged commit 284280a into sagemath:develop Jun 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants