Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from genbg to genbgL in nauty_genbg to generate larger bipartite graphs. #38621

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Sep 5, 2024

Fixes #38618.

genbg was limited to bipartite graphs with up to 32 vertices. Using genbgL, we can go to 64 vertices.

Note that in the doctests, we use the form ...genbg... as currently lines starting with >A contain genbgL while lines starting with >E contain genbg. using this formulation, we are on the safe side.

On the way, we fix the documentation of digraphs.tournaments_nauty().

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Sep 5, 2024

Documentation preview for this PR (built with commit 0dc4a54; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
… generate larger bipartite graphs.

    
Fixes sagemath#38618.

`genbg` was limited to bipartite graphs with up to 32 vertices. Using
`genbgL`, we can go to 64 vertices.

Note that in the doctests, we use the form `...genbg...` as currently
lines starting with `>A` contain `genbgL` while lines starting with `>E`
contain `genbg`. using this formulation, we are on the safe side.

On the way, we fix the documentation of `digraphs.tournaments_nauty()`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38621
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 8, 2024
… generate larger bipartite graphs.

    
Fixes sagemath#38618.

`genbg` was limited to bipartite graphs with up to 32 vertices. Using
`genbgL`, we can go to 64 vertices.

Note that in the doctests, we use the form `...genbg...` as currently
lines starting with `>A` contain `genbgL` while lines starting with `>E`
contain `genbg`. using this formulation, we are on the safe side.

On the way, we fix the documentation of `digraphs.tournaments_nauty()`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38621
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 10, 2024
… generate larger bipartite graphs.

    
Fixes sagemath#38618.

`genbg` was limited to bipartite graphs with up to 32 vertices. Using
`genbgL`, we can go to 64 vertices.

Note that in the doctests, we use the form `...genbg...` as currently
lines starting with `>A` contain `genbgL` while lines starting with `>E`
contain `genbg`. using this formulation, we are on the safe side.

On the way, we fix the documentation of `digraphs.tournaments_nauty()`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38621
Reported by: David Coudert
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 12, 2024
… generate larger bipartite graphs.

    
Fixes sagemath#38618.

`genbg` was limited to bipartite graphs with up to 32 vertices. Using
`genbgL`, we can go to 64 vertices.

Note that in the doctests, we use the form `...genbg...` as currently
lines starting with `>A` contain `genbgL` while lines starting with `>E`
contain `genbg`. using this formulation, we are on the safe side.

On the way, we fix the documentation of `digraphs.tournaments_nauty()`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38621
Reported by: David Coudert
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 2015ab2 into sagemath:develop Sep 15, 2024
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch from genbg to genbgL in the backend of nauty_genbg()
3 participants