Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dependency to commandline arguments parser #217

Merged
merged 1 commit into from
May 4, 2020

Conversation

notbear
Copy link
Contributor

@notbear notbear commented Apr 2, 2020

Adds a direct dependency to commandline arguments parser. As the currently used optimist is deprecated, switching to yargs.

Closes #216

@salesforce-cla
Copy link

salesforce-cla bot commented Apr 2, 2020

Thanks for the contribution! Before we can merge this, we need @notbear to sign the Salesforce.com Contributor License Agreement.

@notbear
Copy link
Contributor Author

notbear commented Apr 15, 2020 via email

@onx2
Copy link

onx2 commented Apr 15, 2020

When can this be merged?

@notbear
Copy link
Contributor Author

notbear commented May 4, 2020

@aputinski @zahnster Can I ask for merge?

@zahnster
Copy link
Contributor

zahnster commented May 4, 2020

Sure @notbear, this looks good! Thanks for the ping. I'll merge.

@zahnster zahnster merged commit 3334fd2 into salesforce-ux:master May 4, 2020
@Norbz
Copy link

Norbz commented May 11, 2020

Hi there,

Thanks for the fix.
Is this possible to have a release for this ? Currently, the latest npm version is broken, and it breaks all the build on our CI. I'd would love not to switch all my projects using theo to a github branch install :)

Thanks !

@notbear notbear deleted the fix/216-missing-optimist branch June 2, 2020 08:11
@LolliDepp
Copy link

Yes if you could please make a release - I think with one of the other updates you removed a dependency which was sneaking in optimist aniway, and now it does not work

@StevenLangbroek
Copy link

hey @zahnster! it looks like there hasn't been a release since january, is that accurate?

fmal added a commit to PowelAS/design-primitives that referenced this pull request Jul 3, 2020
@BirgitPohl
Copy link

When does the release come? As I can see, what is in master is not yet in a new stamped version.
I'd like to use Theo preferably, but can't use it now, because of the issue that persists in the previous versions.

@nicohenao
Copy link

Hi @zahnster ! Thanks for merging this PR, can I ask you to publish a new release to NPM so we get this change? thanks!

@Norbz
Copy link

Norbz commented Sep 3, 2020

Please make a new release for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependency to "optimist" package
8 participants