fix(compat form tag rendering): Fixes issue where form tags could not…

… be rendered (#961)

* integration test for form tag
* fix(form-tag-rendering): Fixes issue where form tags could not be rendered
* remove define Property in uid

packages/lwc-engine/src/framework/modules/uid.ts

@@ -1,4 +1,6 @@
 import { OwnerKey } from "../vm";
+import { defineProperty } from './../language';
+
 
 function updateUID(oldVnode: VNode, vnode: VNode) {
     const { uid: oldUid } = oldVnode;

packages/lwc-engine/src/framework/utils.ts

@@ -71,7 +71,7 @@ export function getAttrNameFromPropName(propName: string): string {
     // otherwise we do the regular canonical transformation.
     return propName.replace(CAPS_REGEX, (match: string): string => '-' + match.toLowerCase());
 }
-
+export const usesNativeSymbols = typeof Symbol() === 'symbol';
 export function noop() {}
 
 const classNameToClassMap = create(null);

packages/lwc-engine/src/framework/vm.ts

@@ -3,14 +3,14 @@ import { getComponentDef } from "./def";
 import { createComponent, linkComponent, renderComponent } from "./component";
 import { patch } from "./patch";
 import { ArrayPush, isUndefined, isNull, keys, defineProperties, ArrayUnshift, ArraySlice } from "./language";
-import { addCallbackToNextTick, noop, EmptyObject } from "./utils";
+import { addCallbackToNextTick, noop, EmptyObject, usesNativeSymbols } from "./utils";
 import { ViewModelReflection } from "./def";
 import { invokeServiceHook, Services } from "./services";
 import { invokeComponentMethod } from "./invoker";
 let idx: number = 0;
 let uid: number = 0;
 
-export const OwnerKey = Symbol('key');
+export const OwnerKey = usesNativeSymbols ? Symbol('key') : '$$OwnerKey$$';
 
 export function addInsertionIndex(vm: VM) {
     if (process.env.NODE_ENV !== 'production') {

packages/lwc-integration/src/components/rendering/test-form-tag/form-tag.html

@@ -0,0 +1,5 @@
+<template>
+    <form>
+        <div class="form-text">Form did render</div>
+    </form>
+</template>

packages/lwc-integration/src/components/rendering/test-form-tag/form-tag.js

@@ -0,0 +1,5 @@
+import { Element } from 'engine';
+
+export default class TestFormTag extends Element {
+
+}

packages/lwc-integration/src/components/rendering/test-form-tag/form-tag.spec.js

@@ -0,0 +1,15 @@
+const assert = require('assert');
+describe('Object keys', () => {
+    const URL = 'http://localhost:4567/form-tag';
+    let element;
+
+    before(() => {
+        browser.url(URL);
+    });
+
+    it('should have the right value', function () {
+        const element = browser.element('.form-text');
+        assert.ok(element);
+        assert.deepEqual(element.getText(), 'Form did render');
+    });
+});