Fix for #41858 #52168 #52161
Closed
Fix for #41858 #52168 #52161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0fik
changed the title
t0fik
changed the title
|
I've added the |
|
@dwoz Extending tests for x509 state would be ok? Or you want new tests for x509 module? |
|
@t0fik I'm guessing new tests so we don't mix testing concerns. However, whatever you think gives best coverage of the change is fine. |
|
@dwoz I should have time to write tests at Easters. |
caught a typo
Separation of concerns, and reduces the amount of mocking that needs to be done in order to isolate bug.
The mock values were obtained by running an acutal query, truncating the list of returned entries and stripping unnecessary keys from the results. The test case runs well with python 2 but causes a traceback with python 3.
With python 3, salt-cloud tracebacks in salt/cloud/clouds/ec2.py's get_imageid when searching for an image name not starting with "ami-". Python 3 removed the cmp parameter in favor of key.
…o another location. This fix ensures that when fsroot is referenced we are using the real path and not the symlink path.
…o another location. This fix ensures that when fsroot is referenced we are using the real path and not the symlink path.
…che-exception Use encoding when caching pillar data
…user_exists_fixes [2019.2] More fixes to mysql module
increase sleep time between kitchen create failures to account for api limits
[2019.2] Update CODEOWNERS github file
add new saltconf ads
modifying saltconf ads
add known issue to relase notes
Update release versions for 2019.2 branch
ghost
requested a review
from
Closed
|
@sagetherage I've messed up on rebasing, so I've created new clean and shiny PR to develop #56367 |
Merged
|
I've also created PR for master branch #56372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix x509.sign_remote_certificate not working after upgrade to 2019.2.0 #51869 issueResolved by Fix issue #51869 and add cert signing test #52381Removes kwargs stringification before pushing them to publish.publish.
Stringification was causing adding redundant unicode identifier to dictionary keys after using salt.utils.yaml.safe_loader.
In 2018.3 yaml loader was cleaning redundant unicode identifiers.
ex: u"u'signing_policy'" instead u'signing_policy'
Fix x509.certificate_managed can write an error message into the cert file instead of failing #41858 and x509.certificate_managed can write an error message as the certificate #52168 issue
Exceptions raised in get_pem_entry was suppressed by salt.utils.files.set_umask. It was leading to writing incorrect values (ex. error message) to destination pem file.
Fixed compound match execution in
sign_remote_certificatematch.compound was called on local (ca_server) not on minion requesting certificate sign