Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #41858 #56372

Merged
merged 21 commits into from
May 7, 2020
Merged

Fix for #41858 #56372

merged 21 commits into from
May 7, 2020

Conversation

t0fik
Copy link
Contributor

@t0fik t0fik commented Mar 13, 2020 •
edited
Loading

Patch for master branch of #52161, due to messed rebasing.

  1. Fix x509.certificate_managed can write an error message into the cert file instead of failing #41858 and x509.certificate_managed can write an error message as the certificate #52168 issue
    Exceptions raised in get_pem_entry was suppressed by salt.utils.files.set_umask. It was leading to writing incorrect values (ex. error message) to destination pem file.
  2. Fixed compound match execution in sign_remote_certificate
    match.compound was called on local (ca_server) not on minion requesting certificate sign

@t0fik
Fixed match compound testing ca server instead requestor, call of get…
6b5674d 
…_pem_entry in write_pem moved outside salt.utils.files.set_umask context
@t0fik t0fik requested a review from a team as a code owner March 13, 2020 16:47
@ghost ghost requested a review from Ch3LL March 13, 2020 16:47
This was referenced Mar 13, 2020
Closed
Closed
@t0fik t0fik changed the title Fixed match compound testing ca server instead requestor, call of get… Fix for #41858 #52168 Mar 13, 2020
@t0fik t0fik changed the title Fix for #41858 #52168 Fix for #41858 #41858 Mar 13, 2020
@t0fik t0fik changed the title Fix for #41858 #41858 Fix for #41858 Mar 14, 2020
@Ch3LL Ch3LL self-assigned this Mar 16, 2020
@Ch3LL Ch3LL removed the request for review from a team April 15, 2020 14:17
@Ch3LL
Copy link
Contributor

Ch3LL commented Apr 29, 2020

looks like there are some failures in pre-commit that need to be cleaned up. You can see the details in the jenkins console output here: https://jenkinsci.saltstack.com/job/pr-pre-commit/job/PR-56372/6/console

@sagetherage sagetherage assigned xeacott and unassigned Ch3LL May 5, 2020
@xeacott
Copy link
Contributor

xeacott commented May 5, 2020

@t0fik Would you be able to update this PR?

@t0fik
Copy link
Contributor Author

t0fik commented May 6, 2020

@xeacott Done.

@dwoz dwoz merged commit 42dccb8 into saltstack:master May 7, 2020
@sagetherage sagetherage added the ZRelease-Sodium retired label label May 18, 2020
@t0fik t0fik mentioned this pull request Jul 16, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeacott xeacott xeacott approved these changes

@Ch3LL Ch3LL Awaiting requested review from Ch3LL

Assignees

@xeacott xeacott

Labels
ZRelease-Sodium retired label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x509.certificate_managed can write an error message into the cert file instead of failing
5 participants
@t0fik @Ch3LL @xeacott @dwoz @sagetherage