-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Visual regression testing using backstopjs #1157
Conversation
f326888
to
c7ec02b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
063a1c2
to
08c470e
Compare
08c470e
to
de2548a
Compare
Did som changes before we merge
|
Hm, when I run
|
@mariuslundgard Did you run |
Yes, it works! (6 tests failing) |
@@ -20,13 +20,17 @@ | |||
"start": "npm run test-studio", | |||
"ecommerce-studio": "gulp ecommerce-studio", | |||
"test-studio": "gulp test-studio", | |||
"backstop-test-studio": "gulp backstop-test-studio", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this script still used or can it be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it's used for updating content.
PS. Would be nice to document how to use these tests in the root README as part of this PR.
* [test] Adding studio * [test] Adding backstop visual regression testing * [test] Adding reference files * [test] Move backstop to test folder and run backstop-test-studio on test * [test] Check that docker is installed and give error message if not
* [test] Adding studio * [test] Adding backstop visual regression testing * [test] Adding reference files * [test] Move backstop to test folder and run backstop-test-studio on test * [test] Check that docker is installed and give error message if not
For designers:
npm backstop-test-studio
to view studio and edit datanpm test:backstop
(while studio is running) to test local changes. (docker required)npm test:backstop:approve
to approve visual changes