Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Remove visual regression testing for now #1443

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Aug 13, 2019

This removes the visual regression testing setup for now. We should prioritize getting it back in at a later point, but as it stands today it doesn't provide much value as the tests are currently failing and seems largely outdated, which also indicates that nobody is really running them on a regular basis. It also creates a lot of delay when initializing a clean checkout of this repo, and when reinstalling node_modules since it triggers a chromium build download which is sometimes incredibly slow.

This PR can be reverted when we figure out a better and more sustainable approach (e.g. a CI environment that can run the tests for us).

Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Can we make a backup branch in case we want to revisit this setup?

@bjoerge
Copy link
Member Author

bjoerge commented Aug 13, 2019

We can either revert commit 9e14760, or go back to the commit/branch where it was originally introduced (in #1157). There's a risk of it diverging from next, though. Do you want to keep it in a branch that can regularily be rebased against next?

@kristofferjs
Copy link
Contributor

Yeah. that would be nice :)

@bjoerge bjoerge merged commit 23f4e08 into next Aug 13, 2019
@bjoerge bjoerge deleted the revert-visual-regression-testing branch August 13, 2019 14:03
@bjoerge
Copy link
Member Author

bjoerge commented Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants