Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with the snacker #1440

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Fix issues with the snacker #1440

merged 3 commits into from
Aug 13, 2019

Conversation

vicmeow
Copy link
Contributor

@vicmeow vicmeow commented Aug 13, 2019

  • Fixed some snacks using the wrong snack kind (danger)
  • Fixed the icon prop type in the snackbar item's action prop
  • Fixed scrollbar appearing when a snackbar is entering

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vicmeow vicmeow merged commit f285758 into next Aug 13, 2019
@vicmeow vicmeow deleted the snackbar-fixes branch August 13, 2019 13:25
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
* [components] fix unused snackbar kind

* [components] fix snackbar item icon prop type

* [components] fix scrollbar appearance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants