Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with the snacker #1440

Merged
merged 3 commits into from
Aug 13, 2019
Merged

Fix issues with the snacker #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b4fdbc
[components] fix unused snackbar kind
vicmeow Aug 13, 2019
73bdaa1
[components] fix snackbar item icon prop type
vicmeow Aug 13, 2019
a46f9c3
[components] fix scrollbar appearance
vicmeow Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@sanity/components/src/snackbar/SnackbarItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default class SnackbarItem extends React.Component {
static propTypes = {
action: PropTypes.shape({
title: PropTypes.string,
icon: PropTypes.func,
icon: PropTypes.node,
callback: PropTypes.func
}),
autoDismissTimeout: PropTypes.number,
Expand Down
2 changes: 1 addition & 1 deletion packages/@sanity/components/src/snackbar/styles/SnackbarItem.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@import "part:@sanity/base/theme/variables-style";

.root {
position: absolute;
position: fixed;
z-index: var(--zindex-modal);
bottom: 0;
right: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/@sanity/desk-tool/src/pane/DocumentsListPane.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ export default withRouterHOC(
if (error) {
return (
<Snackbar
kind="danger"
kind="error"
isPersisted
actionTitle="Retry"
onAction={onRetry}
Expand Down
2 changes: 1 addition & 1 deletion packages/@sanity/desk-tool/src/pane/Editor/Editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,7 +858,7 @@ export default withRouterHOC(
)}
{transactionResult && transactionResult.type === 'error' && (
<Snackbar
kind="danger"
kind="error"
actionTitle="OK"
onAction={onClearTransactionResult}
title={transactionResult.message}
Expand Down
2 changes: 1 addition & 1 deletion packages/@sanity/desk-tool/src/pane/History.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export default class History extends React.PureComponent {
/>
))}
</div>
{error && <Snackbar kind="danger" isPersisted title={error} />}
{error && <Snackbar kind="error" isPersisted title={error} />}
</div>
)
}
Expand Down