Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a user, I expect NMEA pitch/roll sentence to work with OpenCPN #63

Closed
sarfata opened this issue Nov 23, 2017 · 1 comment
Closed

As a user, I expect NMEA pitch/roll sentence to work with OpenCPN #63

sarfata opened this issue Nov 23, 2017 · 1 comment
Labels
feature

Comments

@sarfata
Copy link
Owner

sarfata commented Nov 23, 2017 •
edited
Loading

See Ron's work here:
https://github.com/sarfata/kbox-firmware/pull/61/files#diff-e1a852b1882fac49cb1e32e9192d85e1R70

And @ronzeiller work here:
https://github.com/ronzeiller/kbox-firmware-teensy36/blob/master/src/common/signalk/SKNMEAVisitor.cpp#L60

Official doc on what OpenCPN supports: https://opencpn.org/wiki/dokuwiki/doku.php?id=opencpn:opencpn_user_manual:advanced_features:nmea_sentences
@sarfata sarfata mentioned this issue Nov 23, 2017
Open
11 tasks
@ronzeiller
Copy link
Contributor

Sent PR for sentence for openCPN and Expedition, both tested.
May be settings for NMEA0183 should be possible to make (configurator) as there are some deprecated NMEA0183 sentences but some programs still wants them....
May be your PITCH/ROLL sentence with the 12 fields is still necessary for some old programs or displays.

sarfata added a commit to ronzeiller/kbox-firmware that referenced this issue Nov 27, 2017
@sarfata
Fix XDR sentence test for pitch/roll
db9e0d0 
This matches what OpenCPN and Expedition understand. See issue sarfata#63.
@sarfata sarfata mentioned this issue Nov 27, 2017
Merged
sarfata added a commit that referenced this issue Nov 27, 2017
@sarfata
Merge pull request #78 from ronzeiller/heel-pitch-nmea0183-openCPN
b6b9621 
NMEA0183 for heel, pitch for Expedition & openCPN - closes #63.
@sarfata sarfata closed this as completed Dec 10, 2017
sarfata added a commit that referenced this issue Dec 10, 2017
@sarfata
Squashed 'lib/NMEA2000/' changes from 6835188..38d46ed
0e54564 
38d46ed Compiler warning fixes
0d805a1 Fixes
3be0ec7 Arduino DUE CAN library update
605b6c3 Fix PGN 128259 send length to 8
a332640 Fixes and new features
c66e927 Merge pull request #62 from sarfata/do-not-override-esp8266-pgm-definitions
bd372f3 Merge pull request #63 from sarfata/bugfix/respond-to-query-sent-to-broadcast
61daf41 Fix a bug where we do not respond to info request sent to broadcast
2b31958 The Arduino framework for ESP8266 defines pgm_*

git-subtree-dir: lib/NMEA2000
git-subtree-split: 38d46ed67bbd72ddb2a58c2e83dbfb28fa0a979c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sarfata @ronzeiller