Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken :has with modifier compilation #1937

Closed
fabiospampinato opened this issue Apr 16, 2023 · 1 comment · Fixed by #1938
Closed

Broken :has with modifier compilation #1937

fabiospampinato opened this issue Apr 16, 2023 · 1 comment · Fixed by #1938
Assignees
Labels

Comments

@fabiospampinato
Copy link

I'm on v1.62.0 (latest), and the following:

.foo {
  &:has(+ &) {
    display: none;
  }
}

Is being compiled to this:

.foo:has(.foo) {
  display: none;
}

While instead it should be compiled to this:

.foo:has(+ .foo) {
  display: none;
}

Basically the + inside the :has disappeared.

@fabiospampinato
Copy link
Author

This is working correctly in v1.53, but broken in v1.54, so that should narrow down the search. It looks like it has been broken for a while.

@nex3 nex3 self-assigned this Apr 17, 2023
@nex3 nex3 transferred this issue from sass/sass Apr 17, 2023
nex3 added a commit to sass/sass-spec that referenced this issue Apr 17, 2023
nex3 added a commit that referenced this issue Apr 17, 2023
@nex3 nex3 mentioned this issue Apr 17, 2023
@nex3 nex3 added the bug label Apr 17, 2023
nex3 added a commit that referenced this issue Apr 19, 2023
nex3 added a commit to sass/sass-spec that referenced this issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants