Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add specs for :has(+ &) #1900

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Add specs for :has(+ &) #1900

merged 2 commits into from
Apr 19, 2023

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Apr 17, 2023

See sass/dart-sass#1937

[skip dart-sass]

@nex3 nex3 mentioned this pull request Apr 17, 2023
Merged
tbondwilkinson
tbondwilkinson reviewed Apr 18, 2023
View reviewed changes
Copy link

@tbondwilkinson tbondwilkinson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do other specs now cover the :is() selector? Or are the :is() specs no longer needed?

@nex3
Copy link
Contributor Author

nex3 commented Apr 18, 2023

I had assumed there was also an is.hrx, but it looks like it was just misnamed. I've added it back but renamed it appropriately.

@nex3 nex3 merged commit 50bfcfa into main Apr 19, 2023
@nex3 nex3 deleted the has-parent branch April 19, 2023 22:29
jgerigmeyer added a commit to oddbird/sass-spec that referenced this pull request Apr 21, 2023
@jgerigmeyer
Merge branch 'main' into browser-tests
39acd12 
* main:
  Add specs for :has(+ &) (sass#1900)
  Don't separate out media queries after one has bubbled (sass#1898)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbondwilkinson tbondwilkinson tbondwilkinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @tbondwilkinson