[Color 4] Update tests for color.mix() and color.complement() #1843

dvdherron · 2022-11-24T17:08:38Z

Part of new/updated tests for color spaces.

See: sass/sass#2831

[skip dart-sass]

spec/core_functions/color/mix/both_weights.hrx

spec/core_functions/color/mix/hue_interpolation.hrx

spec/core_functions/color/complement.hrx

dvdherron · 2022-12-13T12:20:24Z

spec/core_functions/color/mix/error.hrx

@@ -39,6 +65,12 @@ a {b: mix(lch(20% -20 0), red)}
 a {b: mix(red, lch(20% -20 0))}

 <===> null_method/non_legacy/color2/error
+Error: $color1: To use color.mix() with non-legacy color red, you must provide a $method.


$color2 should be the cause of the error here, right?

Yeah, good catch

nex3

If you add physical directories for spec/core_functions/color/mix, you'll need to delete mix.hrx—otherwise the test runner won't know which is the real one and will throw an error.

spec/core_functions/color/complement.hrx

spec/core_functions/color/mix/error.hrx

nex3 · 2022-12-13T01:54:59Z

spec/core_functions/color/mix/hue_interpolation.hrx

+
+<===> specified/output.css
+a {
+  b: rgb(145, 116, 0);


Dart Sass returns rgb(145.2072868242, 115.9916273156, -48.1699603699) here. Is it possible that the source of truth you're using is clamping the RGB channels?

Is it possible that the source of truth you're using is clamping the RGB channels?

Correct. I've updated the places where my source of truth isn't as precise. I'll keep an eye out on these going forward.

Looks like this still has a non-negative blue channel. Should I just go ahead and update it with Dart Sass's output?

updated with Dart Sass's output.

spec/core_functions/color/mix/mixed_spaces.hrx

spec/core_functions/color/mix/predefined.hrx

nex3 · 2022-12-13T01:57:50Z

spec/core_functions/color/mix/predefined.hrx

+
+<===> rgb_explicit_method/output.css
+a {
+  b: color(display-p3 0.9 0.93 0.3);


Dart Sass returns color(display-p3 0.9849707148 0.9141322646 0.3079881122) here, which is kind of close but still surprisingly divergent given that. Do you know which one is correct?

I will have to look more into this but I think the Dart Sass version is correct. This mix comes out to color(display-p3 0.8959 0.9307 0.3031) on the ColorJS playground and then gets rounded up it seems. Like you said, all surprisingly different!

The Dart Sass output is the correct one here.

spec/core_functions/color/mix/predefined.hrx

nex3 · 2022-12-13T01:58:56Z

spec/core_functions/color/mix/predefined.hrx

+
+<===> xyz_explicit_method/output.css
+a {
+  b: color(xyz-d50 0.3 0.21 0.02);


Another close but weirdly different output: color(xyz-d50 0.3464867621 0.2923393699 0.0410088495)

fixed the precision to match Dart Sass here.

spec/core_functions/color/mix/hue_interpolation.hrx

dvdherron · 2022-12-15T18:18:08Z

spec/core_functions/color/complement.hrx

+<===> error/null_space/non_legacy/options.yml
+:todo:
+  - dart-sass
+
 <===> error/null_space/non_legacy/input.scss
 a {b: complement(oklch(0.63 0.26 29.2))}


This test should fail since it doesn't provide an interpolation space but it passes, outputting: oklch(0.8967656043 0.1522729881 196.7205341356deg);

dvdherron · 2022-12-15T18:23:59Z

spec/core_functions/color/mix/error.hrx

@@ -60,6 +60,8 @@ Error: $color1: To use color.mix() with non-legacy color lch(20% -20 0deg), you
 <===> null_method/non_legacy/color2/options.yml
 :ignore_for:
  - libsass
+:todo:
+  - dart-sass


I think you have noted this in the wip dart sass PR. I marked this one as to do as well.

spec/core_functions/color/mix/hue_interpolation.hrx

nex3 · 2022-12-16T21:59:08Z

spec/core_functions/color/mix/error.hrx

+  - dart-sass
+
+<===> rectangular_space/input.scss
+a {b: mix(red, blue, $method: oklab)}


Why is this expected to be an error?

This was mistakenly added as an error. I momentarily mixed up which interpolation spaces are valid here, thinking I was working on color.complement()

nex3 · 2022-12-17T01:21:34Z

spec/core_functions/color/mix/hue_interpolation.hrx

+
+<===> specified/output.css
+a {
+  b: rgb(145, 116, 0);


Looks like this still has a non-negative blue channel. Should I just go ahead and update it with Dart Sass's output?

spec/core_functions/color/mix/named.hrx

dvdherron · 2023-01-11T18:35:37Z

spec/core_functions/color/mix/both_weights.hrx

+
+<===> contradiction/output.css
+a {
+  b: rgba(0, 0, 0, 0);


I think this was changed back to rgba(0, 0, 0, 0). Should it still be transparent? @nex3

rgba(0, 0, 0, 0) matches the existing output here. If I recall, we chose to emit this instead of transparent because that keyword had some weird behavior in very old IE versions.

nex3 · 2023-01-18T03:04:44Z

I think we should be able to get these tests passing if we merge main into feature.color-4. In future, it's probably a good idea to avoid merging directly from main into one of these PRs, since the feature branch won't always be up-to-date.

dvdherron added 19 commits October 13, 2022 17:18

update specs for color.mix()

4c89c95

update too few/too many args tests for mix()

d461cea

add initial test for interpolation methods

fa36c63

cleanup

f1570eb

clean up color.mix

669ca49

start editing complement()

63f2150

Merge branch 'main' into color-spaces

ca1e2bc

Merge branch 'main' into color-spaces

57f0565

edit complement and linting

4035a5a

clean up color.complement

abfa764

lint

81ed4a5

edit mix()

2ca693a

Merge branch 'main' into color-spaces

27bdb03

fix output spaces for complement

1e5c5e8

clean up output format

8f789d7

clean up mix()

d11f80d

fix complement errors

b4bfc60

adjust output values

1fb2838

Merge branch 'main' into color-spaces

794e4de

dvdherron changed the title ~~Add tests for color.mix() and color.complement()~~ Update tests for color.mix() and color.complement() Nov 24, 2022

nex3 self-requested a review November 28, 2022 21:43

nex3 requested changes Dec 1, 2022

View reviewed changes

spec/core_functions/color/mix/both_weights.hrx Show resolved Hide resolved

spec/core_functions/color/mix/hue_interpolation.hrx Outdated Show resolved Hide resolved

spec/core_functions/color/complement.hrx Outdated Show resolved Hide resolved

dvdherron changed the base branch from main to feature.color-4 December 1, 2022 13:25

dvdherron added 2 commits December 2, 2022 11:05

review edits

4a49a00

add tests for predefined spaces

e20e4e9

dvdherron requested a review from nex3 December 2, 2022 15:44

Merge branch 'feature.color-4' into color-spaces

92786ed

dvdherron changed the title ~~Update tests for color.mix() and color.complement()~~ [Color 4] Update tests for color.mix() and color.complement() Dec 9, 2022

Update expectations with Dart Sass

8afd2b8

nex3 mentioned this pull request Dec 13, 2022

Fix some bugs in color.complement() and .mix() sass/dart-sass#1845

Merged

dvdherron commented Dec 13, 2022

View reviewed changes

nex3 requested changes Dec 14, 2022

View reviewed changes

nex3 and others added 7 commits December 13, 2022 17:19

Merge remote-tracking branch 'origin/feature.color-4' into color-spaces

db79ae3

fix expectations and review edits

4742231

mark todo and match Dart expectations

0031daa

Merge branch 'main' into color-spaces

8053352

mark hue interpolation methods todo

4e4f359

ignore errors for libsass

505c830

add additional error tests for mix

e81663f

dvdherron commented Dec 15, 2022

View reviewed changes

Update tests to match Dart Sass and remove TODOs

2856998

nex3 force-pushed the color-spaces branch from d3f19c0 to 2856998 Compare December 17, 2022 01:30

nex3 requested changes Dec 17, 2022

View reviewed changes

dvdherron added 2 commits January 9, 2023 11:58

Merge branch 'main' into color-spaces

222d4a5

review edits and update out based on Dart Sass

a5b9530

dvdherron commented Jan 11, 2023

View reviewed changes

dvdherron requested a review from nex3 January 11, 2023 18:36

Merge branch 'feature.color-4' into color-spaces

7de01ee

nex3 merged commit e6687a2 into sass:feature.color-4 Jan 31, 2023

nex3 deleted the color-spaces branch January 31, 2023 20:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Color 4] Update tests for color.mix() and color.complement() #1843

[Color 4] Update tests for color.mix() and color.complement() #1843

dvdherron commented Nov 24, 2022

dvdherron Dec 13, 2022

nex3 Dec 14, 2022

nex3 left a comment

nex3 Dec 13, 2022

dvdherron Dec 14, 2022

nex3 Dec 17, 2022

dvdherron Jan 9, 2023

nex3 Dec 13, 2022

dvdherron Dec 14, 2022

dvdherron Jan 11, 2023

nex3 Dec 13, 2022

dvdherron Jan 9, 2023

dvdherron Dec 15, 2022

dvdherron Dec 15, 2022

nex3 Dec 16, 2022

dvdherron Jan 9, 2023

nex3 Dec 17, 2022

dvdherron Jan 11, 2023

nex3 Jan 18, 2023

nex3 commented Jan 18, 2023

[Color 4] Update tests for color.mix() and color.complement() #1843

[Color 4] Update tests for color.mix() and color.complement() #1843

Conversation

dvdherron commented Nov 24, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nex3 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nex3 commented Jan 18, 2023