Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Color 4] Update tests for color.mix() and color.complement() #1843

Merged
merged 34 commits into from
Jan 31, 2023
Merged

[Color 4] Update tests for color.mix() and color.complement() #1843

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
4c89c95
update specs for color.mix()
dvdherron Oct 13, 2022
d461cea
update too few/too many args tests for mix()
dvdherron Oct 18, 2022
fa36c63
add initial test for interpolation methods
dvdherron Oct 18, 2022
f1570eb
cleanup
dvdherron Oct 18, 2022
669ca49
clean up color.mix
dvdherron Oct 26, 2022
63f2150
start editing complement()
dvdherron Oct 26, 2022
ca1e2bc
Merge branch 'main' into color-spaces
dvdherron Nov 1, 2022
57f0565
Merge branch 'main' into color-spaces
dvdherron Nov 7, 2022
4035a5a
edit complement and linting
dvdherron Nov 7, 2022
abfa764
clean up color.complement
dvdherron Nov 8, 2022
81ed4a5
lint
dvdherron Nov 9, 2022
2ca693a
edit mix()
dvdherron Nov 9, 2022
27bdb03
Merge branch 'main' into color-spaces
dvdherron Nov 9, 2022
1e5c5e8
fix output spaces for complement
dvdherron Nov 16, 2022
8f789d7
clean up output format
dvdherron Nov 18, 2022
d11f80d
clean up mix()
dvdherron Nov 22, 2022
b4bfc60
fix complement errors
dvdherron Nov 22, 2022
1fb2838
adjust output values
dvdherron Nov 22, 2022
794e4de
Merge branch 'main' into color-spaces
dvdherron Nov 24, 2022
4a49a00
review edits
dvdherron Dec 2, 2022
e20e4e9
add tests for predefined spaces
dvdherron Dec 2, 2022
92786ed
Merge branch 'feature.color-4' into color-spaces
dvdherron Dec 9, 2022
8afd2b8
Update expectations with Dart Sass
nex3 Dec 13, 2022
db79ae3
Merge remote-tracking branch 'origin/feature.color-4' into color-spaces
nex3 Dec 14, 2022
4742231
fix expectations and review edits
dvdherron Dec 14, 2022
0031daa
mark todo and match Dart expectations
dvdherron Dec 14, 2022
8053352
Merge branch 'main' into color-spaces
dvdherron Dec 15, 2022
4e4f359
mark hue interpolation methods todo
dvdherron Dec 15, 2022
505c830
ignore errors for libsass
dvdherron Dec 15, 2022
e81663f
add additional error tests for mix
dvdherron Dec 15, 2022
2856998
Update tests to match Dart Sass and remove TODOs
nex3 Dec 16, 2022
222d4a5
Merge branch 'main' into color-spaces
dvdherron Jan 9, 2023
a5b9530
review edits and update out based on Dart Sass
dvdherron Jan 9, 2023
7de01ee
Merge branch 'feature.color-4' into color-spaces
jerivas Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions spec/core_functions/color/mix/hue_interpolation.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

<===>
================================================================================
<===> longer/options.yml
:todo:
- dart-sass

<===> longer/input.scss
a {b: mix(red, green, $method: hsl longer hue)}
nex3 marked this conversation as resolved.
Show resolved Hide resolved

Expand All @@ -14,6 +18,10 @@ a {

<===>
================================================================================
<===> specified/options.yml
:todo:
- dart-sass

<===> specified/input.scss
a {b: mix(red, green, $method: lch specified hue)}

Expand All @@ -24,6 +32,10 @@ a {

<===>
================================================================================
<===> increasing/weighted/options.yml
:todo:
- dart-sass

<===> increasing/weighted/input.scss
a {b: mix(red, green, 20%, lch increasing hue)}

Expand Down
6 changes: 5 additions & 1 deletion spec/core_functions/color/mix/named.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@

<===>
================================================================================
<===> polar_space/options.yml
:todo:
- dart-sass

<===> polar_space/input.scss
a {b: mix($color1: #91e16f, $color2: #0144bf, $weight: 92%, $method: lch decreasing hue)}
a {b: mix($color1: #91e16f, $color2: #0144bf, $weight: 92%, $method: hsl decreasing hue)}

<===> polar_space/output.css
a {
Expand Down