This repository has been archived by the owner on Sep 19, 2021. It is now read-only.
Downgrading dependency to solve issue with conflicting json4s-core versions #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is described here: sbt/sbt-bintray#104
Although I have actually added unit test I am admitting honestly that it doesn't really reproduce the issue. There is a conflict between two jar versions
json4s-core_2.10-3.2.10.jar
vsjson4s-core_2.10-3.2.11.jar
. It seems that version 3.2.11 lost method:emptyValueStrategy
which is attempted to being used byjson4s-native
like here:The problem with reproducing is that
sbt
itself downloadsjson4s-core
whatever you do (if you create empty build.sbt with bare minimum it will pulljson4s-core_2.10-3.2.10.jar
). Therefore I wasn't able to reproduce it in unit testing - i think that it always worksaccidentally
- by picking wrong jar version:With above in mind I am happy to remove this test case from the PR and just leave the fix in sbt (but I leave the decision for the person who would be reviewing this).
The most important part is - that this fixes the issue mentioned here: sbt/sbt-bintray#104 (and all related problems in other projects: EmilDafinov/scala-ad-sdk@3ccbcda or RMSone/slick-cats#26 )