Skip to content
This repository has been archived by the owner on Feb 28, 2021. It is now read-only.

Downgrading dependency to solve issue with json4s-core dependency version conflict #108

Closed
wants to merge 4 commits into from

Conversation

pdolega
Copy link

@pdolega pdolega commented May 19, 2017

Issue described here: #104

Before this can be built successfully we need to have first this guy merged: sbt/bintry#28

It fully reproduces the issue (take a look - just change back "org.foundweekends" %% "bintry" % "0.6.0" to "org.foundweekends" %% "bintry" % "0.5.0" ).

I do however has one critical problem with running sbt-scripted with sbt 1.0.0-M5 (look at comment on PR)

build.sbt Outdated
// sbtVersion in Global := "1.0.0-M5",
// scalaCompilerBridgeSource :=
// ("org.scala-sbt" % "compiler-interface" % "0.13.15" % "component").sources
// )
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the problem - I am not able to deal with the dependencies here:

[info] Resolving org.scala-sbt#launcher;1.0.0 ...
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  ::          UNRESOLVED DEPENDENCIES         ::
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::
[warn]  :: org.scala-sbt#scripted-sbt;1.0.0-M5: not found
[warn]  ::::::::::::::::::::::::::::::::::::::::::::::

I got an impression that sbt-scripted was published somehow differently for 1.0.0

Copy link
Author

@pdolega pdolega May 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that I need to capture somehow the target sbt version here. I think that problem is that scripted plugin for sbt 0.x is called scripted-plugin but for 1.0.0 is called scripted-plugin_2.12. So what I tried in plugins.sbt was something like this (doesn't work though):

def dispatchScriptedName(sbtVersion: String) = {
  println(sbtVersion)
  CrossVersion.sbtApiVersion(sbtVersion) match {
    case Some((1, _)) => "scripted-plugin_2.12"
    case wat => println(wat); "scripted-plugin"
  }
}

libraryDependencies += "org.scala-sbt" % dispatchScriptedName(sbtVersion.value) % sbtVersion.value

@jvican
Copy link
Member

jvican commented Jun 19, 2017

@pdolega This is a great contribution, I'm sorry we didn't chime in before.

I'm updating this PR with my own release of bintry 0.6.0 and all your findings to leave it in a state in which it can be merged. It would be good if you chime in and review my changes too.

@jvican
Copy link
Member

jvican commented Jun 19, 2017

@pdolega Your PR has been rebased to master and I've fixed the scripted failure. Everything should be ok now. Thanks a lot for adding the scripted test.

@jvican
Copy link
Member

jvican commented Jun 19, 2017

CI is failing because 0.6.0 has not been released for bintry. Can someone with merge rights please do so? I can only publish stuff in sbt-bintray, but not in sbt/bintry.

@dwijnand
Copy link
Member

Superseded by #123.

@dwijnand dwijnand closed this Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants