Skip extension method params in WUnused

scala · Mar 29, 2023 · 2a02996 · 2a02996
1 parent d640193
commit 2a02996
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/community-build/community-projects/requests-scala b/community-build/community-projects/requests-scala
diff --git a/compiler/src/dotty/tools/dotc/transform/CheckUnused.scala b/compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
@@ -627,7 +627,7 @@ object CheckUnused:
 
     extension (memDef: tpd.MemberDef)
       private def isValidMemberDef(using Context): Boolean =
-        !memDef.symbol.isUnusedAnnot && !memDef.symbol.isAllOf(Flags.AccessorCreationFlags) && !memDef.name.isWildcard
+        !memDef.symbol.isUnusedAnnot && !memDef.symbol.isAllOf(Flags.AccessorCreationFlags) && !memDef.name.isWildcard && !memDef.symbol.owner.is(Extension)
 
       private def isValidParam(using Context): Boolean =
         val sym = memDef.symbol

diff --git a/tests/neg-custom-args/fatal-warnings/i15503g.scala b/tests/neg-custom-args/fatal-warnings/i15503g.scala
@@ -12,4 +12,11 @@ def f7(a: Int)(using Int) = summon[Int] + a // OK
 
 /* --- Trivial method check --- */
 def g1(x: Int) = 1 // OK
-def g2(x: Int) = ??? // OK
+def g2(x: Int) = ??? // OK
+
+package foo.test.i17101:
+  type Test[A] = A
+  extension[A] (x: Test[A]) { // OK
+    def value: A = x
+    def causesIssue: Unit = println("oh no")
+  }