Ignore parameter of accessors, fixes #16955 (#16957)

@szymon-rd Fixes #16955 - Do not report parameter of accessors - Update test suit
scala · Feb 18, 2023 · f6c57d8 · f6c57d8
2 parents b67daed + d5fd114
commit f6c57d8
Show file tree

Hide file tree

Showing 3 changed files with 48 additions and 2 deletions.
diff --git a/compiler/src/dotty/tools/dotc/transform/CheckUnused.scala b/compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
@@ -80,7 +80,7 @@ class CheckUnused extends MiniPhase:
     ctx
 
   override def prepareForIdent(tree: tpd.Ident)(using Context): Context =
-    if tree.symbol.exists then 
+    if tree.symbol.exists then
       unusedDataApply(_.registerUsed(tree.symbol, Some(tree.name)))
     else if tree.hasType then
       unusedDataApply(_.registerUsed(tree.tpe.classSymbol, Some(tree.name)))
@@ -621,7 +621,7 @@ object CheckUnused:
         (sym.is(Param) || sym.isAllOf(PrivateParamAccessor | Local, butNot = CaseAccessor)) &&
         !isSyntheticMainParam(sym) &&
         !sym.shouldNotReportParamOwner &&
-        (!sym.exists || !sym.owner.isAllOf(Synthetic | PrivateLocal))
+        (!sym.exists || !(sym.owner.isAllOf(Synthetic | PrivateLocal) || sym.owner.is(Accessor)))
 
       private def shouldReportPrivateDef(using Context): Boolean =
         currScopeType.top == ScopeType.Template && !memDef.symbol.isConstructor && memDef.symbol.is(Private, butNot = SelfName | Synthetic | CaseAccessor)

diff --git a/tests/neg-custom-args/fatal-warnings/i15503e.scala b/tests/neg-custom-args/fatal-warnings/i15503e.scala
@@ -52,3 +52,6 @@ package foo.test.trivial:
     def f77(x: Int) = foo // error
   }
   object Y
+
+package foo.test.i16955:
+  class S(var r: String) // OK
diff --git a/tests/neg-custom-args/fatal-warnings/i15503i.scala b/tests/neg-custom-args/fatal-warnings/i15503i.scala
@@ -126,6 +126,49 @@ package foo.test.possibleclasses:
     def a = k + y + s + t + z
   }
 
+package foo.test.possibleclasses.withvar:
+  case class AllCaseClass(
+    k: Int, // OK
+    private var y: Int // OK /* Kept as it can be taken from pattern */
+  )(
+    s: Int, // error /* But not these */
+    var t: Int, // OK
+    private var z: Int // error
+  )
+
+  case class AllCaseUsed(
+    k: Int, // OK
+    private var y: Int // OK
+  )(
+    s: Int, // OK
+    var t: Int, // OK
+    private var z: Int // OK
+  ) {
+    def a = k + y + s + t + z
+  }
+
+  class AllClass(
+    k: Int, // error
+    private var y: Int // error
+  )(
+    s: Int, // error
+    var t: Int, // OK
+    private var z: Int // error
+  )
+
+  class AllUsed(
+    k: Int, // OK
+    private var y: Int // OK
+  )(
+    s: Int, // OK
+    var t: Int, // OK
+    private var z: Int // OK
+  ) {
+    def a = k + y + s + t + z
+  }
+
+
+
 package foo.test.from.i16675:
   case class PositiveNumber private (i: Int) // OK
   object PositiveNumber: