Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive "unused explicit parameter" warning when class has var parameter #16955

Closed
SethTisue opened this issue Feb 18, 2023 · 0 comments · Fixed by #16957
Closed

False positive "unused explicit parameter" warning when class has var parameter #16955

SethTisue opened this issue Feb 18, 2023 · 0 comments · Fixed by #16957
Labels
area:linting Linting warnings enabled with -W or -Xlint itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label
Milestone
3.3.0

Comments

@SethTisue
Copy link
Member

SethTisue commented Feb 18, 2023 •
edited
Loading 

//> using scala "3.nightly"
//> using option "-Wunused:all"

class S(var r: String)
[warn] ./S.scala:4:9: unused explicit parameter
[warn] class S(var r: String)
[warn]         ^

this is with the current nightly (Scala 3.3.1-RC1-bin-20230216-2507577-NIGHTLY). same with 3.3.0-RC3.
@SethTisue SethTisue added itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label area:linting Linting warnings enabled with -W or -Xlint labels Feb 18, 2023
@PaulCoral PaulCoral mentioned this issue Feb 18, 2023
Merged
szymon-rd added a commit that referenced this issue Feb 18, 2023
@szymon-rd
Ignore parameter of accessors, fixes #16955 (#16957)
f6c57d8 
@szymon-rd Fixes #16955

- Do not report parameter of accessors
- Update test suit
Kordyjan added a commit that referenced this issue Apr 17, 2023
@Kordyjan
Backport "Ignore parameter of accessors, fixes #16955" (#17270)
20ebba5 
Backports #16957
@Kordyjan Kordyjan modified the milestones: 3.3.1, 3.3.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:linting Linting warnings enabled with -W or -Xlint itype:bug stat:needs triage Every issue needs to have an "area" and "itype" label
Projects
None yet
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

Ignore parameter of accessors, fixes #16955 PaulCoral/dotty
2 participants
@SethTisue @Kordyjan