Add the -Wall option that enables all warnings
#20545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noti0na1
reviewed
Jun 10, 2024
| val WimplausiblePatterns = BooleanSetting(WarningSetting, "Wimplausible-patterns", "Warn if comparison with a pattern value looks like it might always fail.") | ||
| val WunstableInlineAccessors = BooleanSetting(WarningSetting, "WunstableInlineAccessors", "Warn an inline methods has references to non-stable binary APIs.") | ||
| val Wall: Setting[Boolean] = BooleanSetting(WarningSetting, "Wall", "Enable all warnings.") | ||
| private val overrideWithWall: (Setting[Boolean], (Boolean, Any) => Boolean) = |
There was a problem hiding this comment.
I feel overrideWithWall and all the warning settings are over-engineered. I think a better solution is to create an object which reads all warning settings properly and stores in ctx.
There was a problem hiding this comment.
thanks for the suggestion! I'd appreciate some clarification: does the proposed solution mean that we create another object that takes Wall into consideration when reading all warning settings and store that object in the context (that object could be similar to WunusedHas)? Then at all use sites of these warning settings we read from that object instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18559
This PR adds the
-Walloption, which enables all warnings when it is set. Note that when-Wunusedis not set (empty), setting-Wallis equivalent to passing-Wunused:all. But when-Wunusedis set to some specific value (e.g.-Wunused:imports,locals), passing-Walldoes not change it.