Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the -Wall option that enables all warnings (Plan B) #20577

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Add the -Wall option that enables all warnings (Plan B) #20577

merged 4 commits into from
Aug 22, 2024

Conversation

Linyxus
Copy link
Contributor

@Linyxus Linyxus commented Jun 16, 2024

alternative to #20545

@som-snytt
Copy link
Contributor

th-1967681926

@Gedochao
Copy link
Contributor

Fixes #18559

@Gedochao Gedochao requested a review from noti0na1 June 27, 2024 12:59
@noti0na1 noti0na1 assigned Linyxus and unassigned noti0na1 Jun 27, 2024
@Linyxus
Make WcheckInit public
81f2c8e 
This is needed to make ScalaSettingsTests.scala compile
@Linyxus Linyxus merged commit 8b911ef into scala:main Aug 22, 2024
28 checks passed
@Linyxus Linyxus deleted the wall-alt branch August 22, 2024 12:11
@Linyxus Linyxus mentioned this pull request Aug 22, 2024
Closed
@Gedochao Gedochao linked an issue Aug 22, 2024 that may be closed by this pull request
Add a flag that enables all linting #18559
Closed
@WojciechMazur WojciechMazur mentioned this pull request Aug 28, 2024
Merged
WojciechMazur added a commit that referenced this pull request Aug 28, 2024
@WojciechMazur
Backport "Add the -Wall option that enables all warnings (Plan B)" to…
cd92f06 
… 3.5.2 (#21495)

Backports #20577 to the 3.5.2 branch.

PR submitted by the release tooling.
[skip ci]
@WojciechMazur WojciechMazur added this to the 3.5.2 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noti0na1 noti0na1 noti0na1 approved these changes

Assignees

@Linyxus Linyxus

Labels
None yet
Projects
None yet
Milestone
3.5.2
Development

Successfully merging this pull request may close these issues.

Add a flag that enables all linting
5 participants
@Linyxus @som-snytt @Gedochao @noti0na1 @WojciechMazur