bugfix: Named args completions with default values

[jkciesluk]

No description provided.

[filipwiech]

Could be wrong, but looking at the implementation maybe this could be marked as a @tailrec function? 🙂

[jkciesluk]

You're right, thanks!

[jkciesluk]

Before 3.3.1, the path in this case looks way different -
After 3.3.1:

  Ident(name = CURSOR),
  Apply(
    fun = Apply(fun = Ident(name = deployment), args = List(Literal(const = ( = "str")))),
    args = List(Ident(name = CURSOR))
  ),
  ValDef(
    name = abc,
    tpt = TypeTree[dotty.tools.dotc.core.Types$UnspecifiedErrorType$@2de07d9c],
    preRhs = Apply(
      fun = Apply(fun = Ident(name = deployment), args = List(Literal(const = ( = "str")))),
      args = List(Ident(name = CURSOR))
    )
  )

Before:

  Ident(name = CURSOR),
  ValDef(
    name = DerivedName(underlying = opt, info = NumberedInfo(num = 1)),
    tpt = TypeTree[dotty.tools.dotc.core.Types$PreviousErrorType@44aa396b],
    preRhs = Ident(name = CURSOR)
  ),
  Block(
    stats = List(
      ValDef(
        name = DerivedName(underlying = opt, info = NumberedInfo(num = 1)),
        tpt = TypeTree[dotty.tools.dotc.core.Types$PreviousErrorType@44aa396b],
        preRhs = Ident(name = CURSOR)
      )
    ),
    expr = Block(
      stats = List(
        DefDef(
          name = $anonfun,
          paramss = List(
            List(
              ValDef(
                name = fst,
                tpt = TypeTree[TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class scala)),object Predef),type String)],
                preRhs = Thicket(trees = List())
              ),
              ValDef(
                name = snd,
                tpt = TypeTree[TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class <root>)),object scala),class Int)],
                preRhs = Thicket(trees = List())
              )
            )
          ),
          tpt = TypeTree[AppliedType(TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class <root>)),object scala),class Option),List(TypeRef(TermRef(ThisType(TypeRef(NoPrefix,module class <root>)),object scala),class Int)))],
          preRhs = Apply(
            fun = Apply(
              fun = Apply(fun = Ident(name = deployment), args = List(Literal(const = ( = "str")))),
              args = List(Ident(name = DerivedName(underlying = opt, info = NumberedInfo(num = 1))))
            ),
            args = List(Ident(name = fst), Ident(name = snd))
          )
        )
      ),
      expr = Closure(env = List(), meth = Ident(name = $anonfun), tpt = Thicket(trees = List()))
    )
  )

I will investigate further what can be done for older version

[filipwiech]

Nit: from my perspective a small comment explaining this case would be really welcome (like the very nice remarks in the isDefaultArg function). 🙂

[tgodzik]

Looks good, could you also take a look if the signature help in those cases work correctly?

[jkciesluk]

Looks good, could you also take a look if the signature help in those cases work correctly?

I've fixed it for Scala 2, for Scala 3 it worked fine.
There is one more bug in Scala 3 which should be fixed by scala/scala3#18594

[tgodzik]

Looks good, could you also take a look if the signature help in those cases work correctly?

I've fixed it for Scala 2, for Scala 3 it worked fine. There is one more bug in Scala 3 which should be fixed by lampepfl/dotty#18594

Ok, let's rebase then. I broke the CI before 😓

[filipwiech]

This has been already merged a while ago, so maybe the test could be enabled now. 🙂