deps: bump sbt to 1.8.0 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use 1.8.0 to build sbt-scalafmt, but we use `pluginCrossBuild / sbtVersion` to ensure everything is still working against 1.2.8 by compiling against it.
kitbellew
reviewed
Nov 15, 2022
| @@ -1 +1 @@ | |||
| sbt.version=1.2.8 | |||
| sbt.version=1.8.0 | |||
There was a problem hiding this comment.
@ckipp01 will that mean users of this plugin will have to upgrade their sbt to this version?
There was a problem hiding this comment.
No it doesn't. Since I'm using pluginCrossBuild / sbtVersion := "1.2.8" it ensures that it's still compiling and testing against "1.2.8" even though the build itself is managed with 1.8.0.
You can see some more details about this in https://www.scala-sbt.org/1.x/docs/Plugins.html#Creating+an+auto+plugin.
kitbellew
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use 1.8.0 to build sbt-scalafmt, but we use
pluginCrossBuild / sbtVersionto ensure everything is still working against 1.2.8 by compiling against it.